Radius accounting log search crashes on blank username or iprange

[Kristian Klette]

If one tries searching without a username or iprange a 500 and a stacktrace is returned

URI: '/radius/acctsearch'
Location: None
Directory: '/usr/local/nav/apache/webroot/radius/'
Filename: '/usr/local/nav/apache/webroot/radius/acctsearch'
PathInfo: ''

Phase: 'PythonHandler'
Handler: 'radius'

Traceback (most recent call last):

  File "/usr/lib/python2.4/site-packages/mod_python/importer.py", line 1537, in HandlerDispatch
    default=default_handler, arg=req, silent=hlist.silent)

  File "/usr/lib/python2.4/site-packages/mod_python/importer.py", line 1229, in _process_target
    result = _execute_target(config, req, object, arg)

  File "/usr/lib/python2.4/site-packages/mod_python/importer.py", line 1128, in _execute_target
    result = object(arg)

  File "/usr/local/nav/apache/webroot/radius/radius.py", line 240, in handler
    page.search.loadTable()

  File "/usr/local/nav/apache/webroot/radius/radius.py", line 275, in loadTable
    self.table = self.getTable()

  File "/usr/local/nav/apache/webroot/radius/radius.py", line 746, in getTable
    self.execute()

  File "/usr/local/nav/apache/webroot/radius/radius.py", line 264, in execute
    database.execute(self.sqlQuery, self.sqlParameters)

ProgrammingError: ERROR: syntax error at or near "<<" at character 510

(SELECT
                        acctuniqueid,
                        username,
                        realm,
                        framedipaddress,
                        nasipaddress,
                        nasporttype,
                        acctstarttime,
                        acctstoptime,
                        acctsessiontime,
                        acctoutputoctets,
                        acctinputoctets
                        FROM radiusacct
                         framedipaddress << '') ORDER BY acctstarttime DESC

MODULE CACHE DETAILS

Accessed: Tue Nov 4 11:07:19 2008
Generation: 0

_mp_80da5b29ff130bbf8f155ec7c12b3a65 {
  FileName: '/usr/local/nav/apache/webroot/radius/radius.py'
  Instance: 1 [IMPORT]
  Generation: 2
  Modified: Fri Oct 31 16:14:28 2008
  Imported: Tue Nov 4 11:07:19 2008
  Children: '/usr/local/nav/apache/webroot/radius/radius_config.py'
  Friends: '/usr/local/nav/apache/webroot/radius/radiuslib.py'
}

_mp_c6e45c4469b51d86ae23097a36d322ac {
  FileName: '/usr/local/nav/apache/webroot/radius/radius_config.py'
  Instance: 1 [IMPORT]
  Generation: 1
  Modified: Fri Oct 31 16:14:28 2008
  Imported: Tue Nov 4 11:07:19 2008
}

_mp_745bab0ad81a779bace00b44d1f5b6c0 {
  FileName: '/usr/local/nav/apache/webroot/radius/radiuslib.py'
  Instance: 1 [IMPORT]
  Generation: 3
  Modified: Fri Oct 31 16:14:28 2008
  Imported: Tue Nov 4 11:07:19 2008
}

[Kai Bjørnenak (kai-bjornenak)]

https://heimdal.uit.no/hg/index.cgi/rev/00202cd02d19

[Kai Bjørnenak (kai-bjornenak)]

First fix had unintended sideeffects

[Kai Bjørnenak (kai-bjornenak)]

New fix at: https://heimdal.uit.no/hg/index.cgi/rev/dd1af871662c