distinction between 'review' and 'comment' forms is confusing

[Martin Pool]

Hi,

I'm just doing a review in https://code.edge.launchpad.net/~spiv/bzr-usertest/server-start-stop/+merge/1321

The basic thing I want to do on this page as a reviewer is append a new comment to the bottom. The obvious way to do this is by clicking the 'comment' form. This does let me comment, but not express an actual vote. To do that I need to instead click the 'review' text link in the table at the top.

The distinction is odd.

[Jonathan Lange (jml)]

Martin A, what are your thoughts?

[Tim Penhey (thumper)]

I've been thinking on this a bit lately, and I think that the comment form should show reviewing fields if and only if the person is able to review.

[Aaron Bentley (abentley)]

(basically anyone will be able to review anyhow)

[Martin Pool (mbp)]

2008/11/11 Tim Penhey <email address hidden>:
> I've been thinking on this a bit lately, and I think that the comment
> form should show reviewing fields if and only if the person is able to
> review.

Works for me.

You could also get an easy win by adding a dropdown for the overall
proposal status, again only enabled if the person can use it.
Possibly eventually that should be unified with the individual vote in
some manner, but until we work that out letting you set them in one go
would save roundtrips.

--
Martin <http://launchpad.net/~mbp/>