IrDA baud_rate not configurable at boot
Bug #292779 reported by
Daniele Napolitano
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
irda-utils (Debian) |
Fix Released
|
Unknown
|
|||
irda-utils (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: irda-utils
I made the baud rate of SIR trasmission configurable by /etc/default/
I Ubuntized the irda-utils init script with use of "log_daemon_msg" and "log_end_msg".
Changed in irda-utils: | |
status: | Unknown → New |
Changed in irda-utils (Debian): | |
status: | New → Fix Released |
Changed in irda-utils (Ubuntu): | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hi Daniele,
A few points:
- please submit patches using unidiff format (diff -u) instead of classic diff; classic diffs don't include any context to ensure that the patch will apply correctly if the target file has changed. begin_msg( ) and log_action_ end_msg( ) that are never used? Even if these are meant to be log_daemon_msg() and log_end_msg(), the correct approach is to make irda-utils depend on the package that provides /lib/lsb/ init-functions, not to work around its absence. irda-utils to get the same result.
- why have you provided copies of log_action_
- why should irda-utils call sysctl at all from an init script, instead of installing a file under /etc/sysctl.d? Since the file in /etc/sysctl.d would be a conffile, users could edit that instead of /etc/default/
Unsubscribing ubuntu- main-sponsors for the moment.