bzr: ERROR: exceptions.TypeError: function takes exactly 8 arguments (1 given)

[Vincenzo Di Somma]

bzr pqm-submit -m"[r=XXX, r=YYY] xxxx yyyy xxxxxx"
Checking the working tree is clean ...
bzr: ERROR: exceptions.TypeError: function takes exactly 8 arguments (1 given)

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 849, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 795, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 495, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/pqm/__init__.py", line 109, in run
    tree=tree)
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/pqm/pqm_submit.py", line 204, in submit
    submission.check_tree()
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/pqm/pqm_submit.py", line 139, in check_tree
    for change in self.tree._iter_changes(basis_tree):
TypeError: function takes exactly 8 arguments (1 given)

bzr 1.8 on python 2.5.2 (linux2)
arguments: ['/usr/bin/bzr', 'pqm-submit', "-m[r=John O'Brien, r=Rick McBride] preview master and preview maker parameters aligned, support htts and authentication"]
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  avahi /usr/lib/python2.5/site-packages/bzrlib/plugins/avahi [0.3.0dev0]
  dbus /usr/lib/python2.5/site-packages/bzrlib/plugins/dbus [unknown]
  gtk /usr/lib/python2.5/site-packages/bzrlib/plugins/gtk [0.95.0]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  pqm /usr/lib/python2.5/site-packages/bzrlib/plugins/pqm [1.0.0dev0]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

[James Westby (james-w)]

Hi,

This is actually a bug in bzr-pqm, so I re-assign it there.

I imagine that this has been fixed in a more recent version of that package,
but I can't be sure, where did you install it from?

Thanks,

James

[Vincenzo Di Somma (vds)]

Thanks for re-assigning it, it's standard Intrepid Package...

On Fri, 2008-10-31 at 18:00 +0000, James Westby wrote:
> Hi,
>
> This is actually a bug in bzr-pqm, so I re-assign it there.
>
> I imagine that this has been fixed in a more recent version of that package,
> but I can't be sure, where did you install it from?
>
> Thanks,
>
> James
>
>
> ** Changed in: bzr-pqm
> Product: Bazaar => Bazaar PQM Plugin
>

[John A Meinel (jameinel)]

Technically it is a bug in both Bazaar and bzr-pqm

1) We used to use Tree._iter_changes() for getting info

2) It was made public by renaming it to Tree.iter_changes(), and _iter_changes was just a shell function to call into the real one.

3) We updated bzr-pqm to use the now public .iter_changes() but never produced another .deb file

4) Apparently the _iter_changes() thunk was not kept up to date with .iter_changes() I would have thought we would at least have a trivial test to make sure the thunk was working. So that the older PQM code stopped working.

On another note, this is one downside of disabling Deprecation Warnings in release versions. As otherwise bzr-pqm would have been complaining for quite some time about using a deprecated api. (Those of us using development versions of bzr also use development versions of bzr-pqm so we never see that bzr-pqm has not been packaged to something newer).

A workaround ATM is to install the development version of bzr-pqm with:

mkdir -p ~/.bazaar/plugins
cd ~/.bazaar/plugins
bzr co lp:bzr-pqm pqm

And then it should be used rather than the system install.

[James Henstridge (jamesh)]

There is a more up to date bzr-pqm package in Debian (of 1.3). I'll look at porting it to Gutsy and Intrepid. Once that's done, it can be copied to the appropriate PPAs.

[James Henstridge (jamesh)]

Okay. Hardy and Intrepid packages are available at https://launchpad.net/~jamesh/+archive based on the current Debian release.