speedtch module crashes on loading

[virusek]

#uname -a
Linux virus-pc 2.6.27-7-generic #1 SMP Thu Oct 30 04:18:38 UTC 2008 i686 GNU/Linux

# lsb_release -rd
Description: Ubuntu 8.10
Release: 8.10

Info:
When Speedtouch 330 is connected during livecd boot, booting is interupted by modprobe crash.
I distonnected Speedtouch 330, it booted right, when i connect again dmesg show following info

[ 1158.208028] usb 2-2: new full speed USB device using ohci_hcd and address 2
[ 1158.442063] usb 2-2: configuration #1 chosen from 1 choice
[ 1159.188909] BUG: unable to handle kernel NULL pointer dereference at 00000000
[ 1159.188920] IP: [<c037d5e5>] __mutex_lock_slowpath+0x35/0xb0
[ 1159.188930] *pde = 00000000
[ 1159.188934] Oops: 0002 [#1] SMP
[ 1159.188939] Modules linked in: speedtch(+) ppp_deflate zlib_deflate bsd_comp ueagle_atm pppoatm ipv6 ppp_generic slhc binfmt_misc rfcomm bridge stp bnep sco l2cap bluetooth ppdev cpufreq_powersave cpufreq_stats cpufreq_userspace cpufreq_ondemand cpufreq_conservative freq_table video output container wmi sbs pci_slot sbshc battery iptable_filter ip_tables x_tables ac parport_pc lp parport psmouse serio_raw joydev evdev pcspkr nvidia(P) usbatm snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm_oss snd_mixer_oss snd_pcm snd_seq_dummy snd_seq_oss snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq snd_timer snd_seq_device button snd shpchp pci_hotplug soundcore i2c_nforce2 snd_page_alloc i2c_core nvidia_agp agpgart reiserfs usbhid hid sr_mod cdrom sd_mod crc_t10dif sg ata_generic pata_amd pata_acpi libata scsi_mod ohci_hcd ehci_hcd dock forcedeth usbcore thermal processor fan fbcon tileblit font bitblit softcursor fuse [last unloaded: ueagle_atm]
[ 1159.189012]
[ 1159.189017] Pid: 6207, comm: modprobe Tainted: P (2.6.27-7-generic #1)
[ 1159.189020] EIP: 0060:[<c037d5e5>] EFLAGS: 00010246 CPU: 0
[ 1159.189025] EIP is at __mutex_lock_slowpath+0x35/0xb0
[ 1159.189028] EAX: edd47c80 EBX: ede7546c ECX: ede75474 EDX: 00000000
[ 1159.189031] ESI: ede75470 EDI: 00000000 EBP: edd47c98 ESP: edd47c78
[ 1159.189034] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
[ 1159.189038] Process modprobe (pid: 6207, ti=edd46000 task=d1b3a5b0 task.ti=edd46000)
[ 1159.189041] Stack: d1b3a5b0 ede75474 ede75474 ccd6e1d0 ccd6e124 ede7546c ede75400 00000000
[ 1159.189049] edd47ca4 c037d43c ee3df200 edd47cc4 f0b40074 ee3df200 ede7546c ccd8c800
[ 1159.189056] ee3df200 ee3df21c 00000000 edd47ce0 f08b3880 f0e22320 ccd8c800 ee3df294
[ 1159.189064] Call Trace:
[ 1159.189067] [<c037d43c>] ? mutex_lock+0x1c/0x20
[ 1159.189072] [<f0b40074>] ? usbatm_usb_disconnect+0x34/0x230 [usbatm]
[ 1159.189083] [<f08b3880>] ? usb_unbind_interface+0x50/0xf0 [usbcore]
[ 1159.189117] [<c02c3a19>] ? __device_release_driver+0x79/0xc0
[ 1159.189125] [<c02c3b38>] ? device_release_driver+0x28/0x40
[ 1159.189131] [<f08b39af>] ? usb_driver_release_interface+0x8f/0xa0 [usbcore]
[ 1159.189148] [<f08b3a5b>] ? usb_forced_unbind_intf+0x1b/0x30 [usbcore]
[ 1159.189165] [<f08abf24>] ? usb_reset_device+0xa4/0x160 [usbcore]
[ 1159.189181] [<f0e20528>] ? speedtch_bind+0x398/0x5e0 [speedtch]
[ 1159.189189] [<f0e20190>] ? speedtch_bind+0x0/0x5e0 [speedtch]
[ 1159.189196] [<f0b419cd>] ? usbatm_usb_probe+0x11d/0x874 [usbatm]
[ 1159.189204] [<c01c7075>] ? iput+0x25/0x60
[ 1159.189213] [<c02001b8>] ? sysfs_add_one+0x18/0x50
[ 1159.189219] [<c037d430>] ? mutex_lock+0x10/0x20
[ 1159.189223] [<c037d3d8>] ? mutex_unlock+0x8/0x20
[ 1159.189229] [<f08b2e19>] ? usb_autopm_do_device+0x69/0xf0 [usbcore]
[ 1159.189245] [<f0e1f012>] ? speedtch_usb_probe+0x12/0x20 [speedtch]
[ 1159.189252] [<f08b34e7>] ? usb_probe_interface+0xa7/0x140 [usbcore]
[ 1159.189269] [<c0201107>] ? sysfs_create_link+0x17/0x20
[ 1159.189277] [<c02c3d4e>] ? really_probe+0xee/0x190
[ 1159.189284] [<f08b28a9>] ? usb_match_id+0x49/0x60 [usbcore]
[ 1159.189303] [<c02c3e33>] ? driver_probe_device+0x43/0x60
[ 1159.189308] [<c02c3ec9>] ? __driver_attach+0x79/0x80
[ 1159.189314] [<c02c3593>] ? bus_for_each_dev+0x53/0x80
[ 1159.189321] [<c02c3b6e>] ? driver_attach+0x1e/0x20
[ 1159.189325] [<c02c3e50>] ? __driver_attach+0x0/0x80
[ 1159.189330] [<c02c2f37>] ? bus_add_driver+0x1b7/0x230
[ 1159.189337] [<c02c409e>] ? driver_register+0x6e/0x150
[ 1159.189343] [<c012a571>] ? hrtick_start_fair+0x181/0x1a0
[ 1159.189352] [<f08b37bc>] ? usb_register_driver+0x7c/0xf0 [usbcore]
[ 1159.189370] [<f0991000>] ? speedtch_usb_init+0x0/0x1e [speedtch]
[ 1159.189376] [<f099101c>] ? speedtch_usb_init+0x1c/0x1e [speedtch]
[ 1159.189381] [<c0101120>] ? _stext+0x30/0x160
[ 1159.189386] [<c012b4ee>] ? try_to_wake_up+0xde/0x290
[ 1159.189392] [<c014c604>] ? __blocking_notifier_call_chain+0x14/0x70
[ 1159.189403] [<c015c208>] ? sys_init_module+0x88/0x1b0
[ 1159.189412] [<c0103f7b>] ? sysenter_do_call+0x12/0x2f
[ 1159.189417] =======================
[ 1159.189419] Code: e2 7c d8 ff 89 c3 8d 73 04 64 a1 00 c0 50 c0 89 45 e0 89 f0 e8 4d 10 00 00 8b 53 0c 8d 45 e8 8d 4b 08 89 4d e4 89 43 0c 89 4d e8 <89> 02 8b 45 e0 89 55 ec ba ff ff ff ff 89 45 f0 89 d0 87 03 83
[ 1159.189456] EIP: [<c037d5e5>] __mutex_lock_slowpath+0x35/0xb0 SS:ESP 0068:edd47c78
[ 1159.189463] ---[ end trace be029e36534bc443 ]---

[mateusz (matmal1)]

When I load module speedtch (# modprobe speedtch) before plugin device then i get:

# sudo /sbin/ifup ppp0

ppp0: ERROR while getting interface flags: No such device
Plugin pppoatm.so loaded.
Using interface ppp0
Connect: ppp0 <--> 0.35
CHAP authentication failed: duplicate address detected
CHAP authentication failed
Connection terminated.
Using interface ppp0
Connect: ppp0 <--> 0.35
CHAP authentication succeeded
CHAP authentication succeeded
Cannot determine ethernet address for proxy ARP
local IP address xx x x x x
remote IP address xxxxxx
primary DNS address xxxxxxx
secondary DNS address xxxxxx

- I have connection.

[mateusz (matmal1)]

maybe this will help:
2008-11-01 21:17:10 wypas kernel [ 92.708942] usbcore: registered new interface driver speedtch
2008-11-01 21:17:33 wypas kernel [ 115.784043] usb 1-1: new full speed USB device using ohci_hcd and address 2
2008-11-01 21:17:33 wypas kernel [ 116.033380] usb 1-1: configuration #1 chosen from 1 choice
2008-11-01 21:17:34 wypas kernel [ 116.716031] usb 1-1: reset full speed USB device using ohci_hcd and address 2
2008-11-01 21:17:34 wypas kernel [ 116.930272] usb 1-1:1.2: rebind failed: -19
2008-11-01 21:17:34 wypas kernel [ 116.930286] usb 1-1:1.1: rebind failed: -19
2008-11-01 21:17:34 wypas kernel [ 116.933413] firmware: requesting speedtch-1.bin.2.00
2008-11-01 21:17:34 wypas kernel [ 116.945478] speedtch 1-1:1.1: speedtch_bind: failed to claim interface 0 (-16)!
2008-11-01 21:17:34 wypas kernel [ 116.945496] speedtch 1-1:1.1: usbatm_usb_probe: bind failed: -16!
2008-11-01 21:17:34 wypas kernel [ 116.950012] speedtch: probe of 1-1:1.1 failed with error -16
2008-11-01 21:17:34 wypas kernel [ 116.956140] speedtch 1-1:1.2: speedtch_bind: failed to claim interface 0 (-16)!
2008-11-01 21:17:34 wypas kernel [ 116.956155] speedtch 1-1:1.2: usbatm_usb_probe: bind failed: -16!
2008-11-01 21:17:34 wypas kernel [ 116.956167] speedtch: probe of 1-1:1.2 failed with error -16
2008-11-01 21:17:34 wypas kernel [ 116.977011] speedtch 1-1:1.0: found stage 1 firmware speedtch-1.bin.2.00
2008-11-01 21:17:34 wypas kernel [ 116.977026] firmware: requesting speedtch-2.bin.2.00
2008-11-01 21:17:35 wypas kernel [ 117.390931] speedtch 1-1:1.0: found stage 2 firmware speedtch-2.bin.2.00
2008-11-01 21:17:40 wypas kernel [ 122.929076] ATM dev 0: ADSL line is synchronising
2008-11-01 21:17:51 wypas kernel [ 133.704057] ATM dev 0: DSL line goes up
2008-11-01 21:17:51 wypas kernel [ 133.713081] ATM dev 0: ADSL line is up (1312 kb/s down | 320 kb/s up)
2008-11-01 21:17:53 wypas kernel [ 135.560709] ppdev0: registered pardevice
(...)
2008-11-01 21:17:53 wypas kernel [ 135.612462] ppdev0: unregistered pardevice
2008-11-01 21:17:54 wypas kernel [ 136.316194] ppdev0: registered pardevice
(...)
2008-11-01 21:17:54 wypas kernel [ 136.364223] ppdev0: unregistered pardevice
(...)
2008-11-01 21:17:56 wypas kernel [ 138.613191] NET: Registered protocol family 10

[virusek (tapcio)]

I compiled fixed speedtch.ko for 2.6.27.2 kernel on Interpid, patch is in kernel bug #11767 (http://bugzilla.kernel.org/show_bug.cgi?id=11767)

[Leann Ogasawara (leannogasawara)]

Hi virusek,

Thanks for the reference to the upstream patch. I'm including the upstream git commit id for the kernel team to reference. I'll go ahead and open an Intrepid nomination to try to get this patch pulled in as an SRU (Stable Release Update). Thanks.

ogasawara@emiko:~/linux-2.6$ git log ./drivers/usb/atm/speedtch.c
commit 8fc7aeab3851ed8c3ecf28901ca2c6f0400955c7
Author: Alan Stern <email address hidden>
Date: Mon Oct 20 09:52:12 2008 -0400

    USB: Speedtouch: add pre_reset and post_reset routines

    This patch (as1150) fixes a problem in the speedtch driver. When it
    resets the modem during probe it will be unbound from the other
    interfaces it has claimed, because it doesn't define a pre_reset and a
    post_reset method.

    The patch defines "do-nothing" methods. This fixes Bugzilla #11767.

    Signed-off-by: Alan Stern <email address hidden>
    Cc: stable <email address hidden>
    Signed-off-by: Greg Kroah-Hartman <email address hidden>

[Martin West (martin-objectgizmos)]

fyi - Im getting the same problem with the stingray modem on 2.6.27-7-generic lastest kernel at this time. Ill try the patched speedtch.ko.

Ive attached the dmesg output for reference.
Thanks

PS this would be a show stopper for me since I run a web server on a different machine using the 330 modem.

[Martin West (martin-objectgizmos)]

catch 22 - wrong kernel - DOH - Ill try the work around.

[Leann Ogasawara (leannogasawara)]

Hi Everyone,

The upstream patch which should resolve this bug was applied when we pulled in the upstream 2.6.27.4 stable patch set. See bug 294155 . I'm going to mark this as a duplicate of bug 294155 . If you could please test the 2.6.27-8.17 available in the intrepid-proposed repository and provide your feedback to bug 294155 that would be great. For information on how to enable intrepid-proposed please see https://wiki.ubuntu.com/Testing/EnableProposed . Thanks.