CMFUid should call reindexObject on the object getting a uid, not on the catalog
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Zope CMF buildout |
Fix Released
|
Low
|
Unassigned |
Bug Description
Currently when the UniqueIdHandlerTool adds a uid to an object, it reindexes that object so the uid catalog can be updated. However, it does so by calling portal_
I'm attaching a patch which fixes this by trying to call the reindexObject attribute of the object getting the uid. I now have zope svn access and am happy to commit this, but wanted to make sure it is reviewed first as it would be my first CMF contribution.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
David Glick wrote: catalog. reindexObject rather than the
> Public bug reported:
>
> Currently when the UniqueIdHandlerTool adds a uid to an object, it
> reindexes that object so the uid catalog can be updated. However, it
> does so by calling portal_
> reindexObject of the object getting the uid. This makes a difference in
> the case of objects like the portal root which should never be
> catalogued, and thus do not subclass CMFCatalogAware and have empty
> indexing methods. The current CMFUid behavior results in such objects
> getting catalogued anyway.
>
> I'm attaching a patch which fixes this by trying to call the
> reindexObject attribute of the object getting the uid. I now have zope
> svn access and am happy to commit this, but wanted to make sure it is
> reviewed first as it would be my first CMF contribution.
+1. The patch (including the test, thank you!) looks fine.
Tres. ======= ======= ======= ======= ======= ======= ======= ======= ==== palladion. com enigmail. mozdev. org
- --
=======
Tres Seaver +1 540-429-0999 <email address hidden>
Palladion Software "Excellence by Design" http://
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iD8DBQFJCcsv+ gerLs4ltQ4RAmQ+ AKCP+/V5OP18TcN o+IM7TmHRaVFc3g CfZV/g 2yak2Jew=
9nEqAZFnxiOhfPB
=sgMo
-----END PGP SIGNATURE-----