[intrepid] Status icons in jockey don't fit icon theme

Bug #290239 reported by Vadim Peretokin
4
Affects Status Importance Assigned to Milestone
jockey (Ubuntu)
Fix Released
Undecided
Martin Pitt

Bug Description

Binary package hint: jockey-gtk

The silver deactivated and green activated icons are completely out of the Ubuntu theme and don't fit in.

Tags: intrepid
Revision history for this message
Martin Pitt (pitti) wrote :

Hm, Ken, any idea for something that would fit better?

Changed in jockey:
assignee: nobody → kwwii
Revision history for this message
Kenneth Wimer (kwwii) wrote :

after looking at them in the interfae I have to admit that they don't fit. I will see if I can come up with something that fits better with the human icons.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

To me they look ok in Human, though the green is a bit yellowish, and it's odd that the "Deactivate" bulb appears smaller than the "This driver is activated" one.

In DarkRoom they have an incongruous grey border, so I guess the relief effects should be done relative to a transparent background instead of a grey one.

Revision history for this message
Kenneth Wimer (kwwii) wrote :

I've tweaked them a bit, ideas?

Revision history for this message
Vadim Peretokin (vperetokin) wrote :

That does look somewhat better, but not exactly fitting. I find that ubuntu's icons have their reflection in an arc and on top, like the help icon's (where you have firefox evoution help on top)

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Vadim, the help icon is a slightly outset solid disc, while the hardware driver status icons are transparent bulbs. Different 3-D shapes, different materials, different reflections.

Ken, that looks much better, nicely done. Now if you increase the radius by a fraction of a pixel, that should eliminate those little grey spikes visible at the cardinal points against the grey background.

Revision history for this message
Kenneth Wimer (kwwii) wrote :
Revision history for this message
Kenneth Wimer (kwwii) wrote :
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks a lot, Ken!

Changed in jockey:
assignee: kwwii → pitti
status: New → In Progress
Revision history for this message
Vadim Peretokin (vperetokin) wrote : Re: [Bug 290239] Re: [intrepid] Status icons in jockey don't fit icon theme

That looks much better. Thank you

Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in upstream trunk.

Changed in jockey:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package jockey - 0.5~beta3-0ubuntu8

---------------
jockey (0.5~beta3-0ubuntu8) jaunty; urgency=low

  * Merge bug fixes from trunk:
    - Replace enabled/disabled icons with more decent variant, thanks Kenneth
      Wimer! (LP: #290239)
    - backend.py: Rewrite timeout behaviour for more robustness; do not time
      out right after a long method call.
    - Intercept crashes of the backend (which manifest as D-BUS NoReply
      error), present an error message, and restart backend. (LP: #273600)
    - jockey-gtk: Fix crash if nothing is selected in the tree view after an
      operation. (LP: #283887)
    - fglrx.py: Unconfigured driver defaults to ati, which already provides
      compositing. (LP: #285879)
  * jockey/oslib.py, install_package(): Use --force-confnew to fix hang/crash
    on "EOF on stdin at conffile prompt", since the jockey backend does not
    have any terminal or interactivity. This fixes fglrx install failure when
    the upstream installer was previously used. This still keeps .dpkg-old
    configuration backups, and using a tool like Jockey should "make it work".
    (LP: #283765)
  * data/handlers/b43.py: Add missing OSLib import. (LP: #295530)

 -- Martin Pitt <email address hidden> Mon, 24 Nov 2008 20:31:53 +0100

Changed in jockey:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.