[0.3]Patch to convert radio, covers, and lyrics managers/plugins to provider system

[Dan O'Reilly]

Attached is a patch that converts the radio, lyrics, and covers managers and their plugins to use the provider system. Its fairly well tested, but some of the functionality isn't easy to test since the features can't actually be accessed through the GUI yet, so you guys may want to take a close look at it and make sure I didn't screw something up :).

[reacocard (reacocard)]

This patch fails the testsuite horribly - 17 tests failed.

[Dan O'Reilly (oreilldf)]

The testsuite didn't work on my system...I figured it hadn't been kept up-to-date. It looks like my checkout has a bunch of files in it that had been deleted from the main repository but didn't get deleted from my copy for some reason, which was causing it to fail before any tests ran. I'll make them all pass and resubmit.

[Dan O'Reilly (oreilldf)]

Try #2. I kept the SimpleManager around this time and just had it subclass ProviderHandler. I thought that this approach made sense since LyricsManager and CoverManager were both doing a lot of the same things and getting rid of SimpleManager would mean duplicating some code. If you'd rather the SimpleManager go away completely I can refactor as needed.

[reacocard (reacocard)]

I'd really prefer not to have it at all - after all, the point of 0.3 is to simplify the codebase, not make it more complex. :) However the patch does apply cleanly and has no regressions that I can see.

[Dan O'Reilly (oreilldf)]

Fair enough, no more SimpleManager. I also added an event log entry for the add/removal of a lyrics or cover search method.

[reacocard (reacocard)]

committed in r420