timestamps of fetched files are wrong
Bug #287964 reported by
Anders F Björklund
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Smart Package Manager |
Fix Released
|
Low
|
Gustavo Niemeyer | ||
Bug Description
The timestamps of fetched files seem to be off by an hour (or more), causing smart to refetch files that haven't really changed...
This is especially painful with slack and arch channels, since those rely on the timestamp rather than an initial small file to fetch.
The "If-Modified-Since" header on the subsequent fetches is supposed to match the "Last-Modified" received in the first fetch.
It isn't, at least not with the urllib fetcher. Things might be better with pycurl, but it could also be a localtime vs. gmtime issue ?
Revision history for this message
| Anders F Björklund (afb) wrote | #1 |
| Changed in smart: | |
| importance: | Undecided → Low |
| milestone: | none → 1.2 |
Revision history for this message
| Gustavo Niemeyer (niemeyer) wrote | #2 |
| Changed in smart: | |
| status: | New → Fix Committed |
| Changed in smart: | |
| assignee: | nobody → niemeyer |
| milestone: | 1.3 → 1.2 |
Revision history for this message
| Anders F Björklund (afb) wrote | #3 |
| Changed in smart: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Patch applied in the trip-work branch. Nice catch!