bzr log should not complain about broken pipe

Bug #2859 reported by Martin Pool
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Unassigned

Bug Description

It is common to do "bzr log|less" and then quit less partway through the history. This produces the error "bzr: broken pipe".

The error is correct - the pipe was broken - but probably not helpful in this situation, where from the user's point of view they simply quit the log viewer.

The best fix seems to be to specifically catch and suppress IOError EPIPE in cases where we know it's harmless.

See thread "bzr questions" on 2005-09-28.

Revision history for this message
John A Meinel (jameinel) wrote :

But to clarify, we should not always suppress the broken pipe.
For instance if you did:
bzr commit -m "committing" | less

It would be possible to abort the commit, because it does print things out to the pipe, and might block waiting for it (you would have to have a lot of changes, though).

Revision history for this message
Aaron Bentley (abentley) wrote :

Fixed in my branch.

Aaron Bentley (abentley)
Changed in bzr:
status: New → PendingUpload
John A Meinel (jameinel)
Changed in bzr:
status: PendingUpload → Fixed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.