acpid initscript speedup

Bug #285531 reported by Alexander Butenko
6
Affects Status Importance Assigned to Milestone
acpid (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: acpid

in order to build list of loaded modules we getting this information from /proc/modules instead of running extra external command

got rid of find (1) and grep (1) in favor of checking files with '-f '.

using insmod instead of modprobe because acpi modules dont have any depends.

Tags: patch
Revision history for this message
Alexander Butenko (avb) wrote :
Revision history for this message
Daniel Hahler (blueyed) wrote :

Thank you for your patch, which looks interesting.

Can you please attach it as a unified patch ("diff -u")? This makes it more robust against other code changes, so it can be reviewed later (instead of not applying anymore)

Changed in acpid:
status: New → Incomplete
Revision history for this message
Alexander Butenko (avb) wrote :
Revision history for this message
Alexander Butenko (avb) wrote :

patch speedup a process for a while, but ideal way is to get rid of insmod here and just compile acpi stuff in kernel. We are not gaining nothing having them as modules once we are not dealing with apm stuff anymore.

Revision history for this message
Daniel Hahler (blueyed) wrote :

Thank you for updating the patch.

I'm marking the bug as triaged and hopefully someone who can make more sense out of it than me gets around incorporating it.

Changed in acpid:
importance: Undecided → Wishlist
status: Incomplete → Triaged
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Subscribed sponsors

Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :

Here is a debdiff that fixes it for Jaunty.

Revision history for this message
Colin Watson (cjwatson) wrote :

Martin, there is really no need to "reformat" plain 'diff -u' patches as debdiffs; they can be sponsored perfectly well without this. (Any developer worth their salt can apply a patch and add a changelog entry.)

If you do reformat a patch as a debdiff, you must credit the original contributor! It's not fair to take their work and not mention them.

Colin Watson (cjwatson)
Changed in acpid:
assignee: nobody → kamion
Revision history for this message
Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount) wrote :

Sorry. I heard about it being easier for uploaders, if the patch already exists as a debdiff.

Revision history for this message
Colin Watson (cjwatson) wrote :

That's an old myth; it doesn't. (It might make five seconds difference, perhaps, but certainly not enough to justify the effort.)

Changed in acpid:
assignee: kamion → scott
Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

Sorry, missed this one being assigned to me - will look in karmic

Revision history for this message
Scott James Remnant (Canonical) (canonical-scott) wrote :

Instead we dropped all that and ported acpid to use upstart

Changed in acpid (Ubuntu):
assignee: Scott James Remnant (scott) → nobody
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.