Client should not collect custom-graphs data if the server doesn't accept the message type anymore

[Thomas Herve]

Currently, if a computer is removed from the system, the accepted-types is updated, so it'll stop sending message, but will continue launching script and collect data from existing custom graphs. It should check the accepted types at each run to see if it should continue to produce data.

[Thomas Herve (therve)]

This is ready to review in the attached branch.

[Kevin McDermott (bigkevmcd)]

Nice fix, +1

Does this mean that we should implement some sort of blocker on the server side?

(Obviously the synchronisation deals with removed graphs, but should the server have a way to halt the client data?)

[Gustavo Niemeyer (niemeyer)]

[1]

The basic idea looks good, but it'd be good to clean it up a bit. Specifically, continue_run() should be a method on the class. Note that most of run()'s body is a closure, and most the variables that are defined outside of continue_run() (and still in the body of run()) are never actually used outside of the closure, so they may be part of the new class method itself, and there's no need for the closure.

+1 with this!

[Gustavo Niemeyer (niemeyer)]

Kevin, I don't get what you mean by a blocker on the server side.

[Thomas Herve (therve)]

Merged in r67.

[Andreas Hasenack (ahasenack)]

qa + 1, works nicely. There is one side effect though, which is not the fault of this fix: the client immediately tries to register again :)

[Andreas Hasenack (ahasenack)]

There is no client release in this milestone, so I'm pushing this to the next one (mountainview-pre-1).