Last byte of FLAC image buffer chopped off

Bug #282434 reported by John Millikin
2
Affects Status Importance Assigned to Milestone
gst-plugins-base
Fix Released
Medium
gst-plugins-base0.10 (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

``gst_tag_image_data_to_image_buffer()`` tries to do some sort of magic with
NULL termination bytes and data lengths, but it's reporting the image's buffer
to be one byte too small. This is because when the buffer is allocated with
image_data_len + 1 bytes, its size is reported as image_data_len. When it's
resized later on line 437, it's resized to image_data_len - 1 bytes.

Reported upstream at http://bugzilla.gnome.org/show_bug.cgi?id=556066 , I've also posted a patch to that bug report that fixes the issue for me.

description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report, the bug has been fixed upstream now

Changed in gst-plugins-base0.10:
importance: Undecided → Low
status: New → Fix Committed
Changed in gst-plugins-base:
status: Unknown → Confirmed
Changed in gst-plugins-base:
status: Confirmed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Fixed with sync of gst-plugins-base0.10 0.10.21-3 from Debian experimental.

Getting binaries for intrepid...
[Updating] gst-plugins-base0.10 (0.10.21-1 [Ubuntu] < 0.10.21-3 [Debian])
 * Trying to add gst-plugins-base0.10...
  - <gst-plugins-base0.10_0.10.21-3.diff.gz: downloading from http://ftp.debian.org/debian/>
  - <gst-plugins-base0.10_0.10.21.orig.tar.gz: already in distro - downloading from librarian>
  - <gst-plugins-base0.10_0.10.21-3.dsc: downloading from http://ftp.debian.org/debian/>
I: gst-plugins-base0.10 [main] -> gstreamer0.10-plugins-base-apps_0.10.21-1 [main].
I: gst-plugins-base0.10 [main] -> gstreamer0.10-plugins-base-doc_0.10.21-1 [main].
I: gst-plugins-base0.10 [main] -> libgstreamer-plugins-base0.10-0_0.10.21-1 [main].
I: gst-plugins-base0.10 [main] -> libgstreamer-plugins-base0.10-dev_0.10.21-1 [main].
I: gst-plugins-base0.10 [main] -> gstreamer0.10-alsa_0.10.21-1 [main].
I: gst-plugins-base0.10 [main] -> gstreamer0.10-gnomevfs_0.10.21-1 [main].
I: gst-plugins-base0.10 [main] -> gstreamer0.10-plugins-base_0.10.21-1 [main].
I: gst-plugins-base0.10 [main] -> gstreamer0.10-plugins-base-dbg_0.10.21-1 [main].
I: gst-plugins-base0.10 [main] -> gstreamer0.10-x_0.10.21-1 [main].

Changed in gst-plugins-base0.10:
status: Fix Committed → Fix Released
Changed in gst-plugins-base:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.