Bug #28067 “[PATCH] initscripts: checkroot.sh ignores fsck resul...” : Bugs : sysvinit package : Ubuntu

Revision history for this message

In Debian Bug tracker #342160, Thomas Hood (jdthood-yahoo) wrote on 2005-12-10: Re: checkroot.sh ignores fsck result

#1

tags 342160 pending
stop

Ilguiz Latypov wrote:
> The /etc/init.d/checkroot.sh script ignored the fsck's "PLEASE REBOOT
> LINUX NOW" exit code because the code is stored too late.

Thanks for reporting this.

The bug has been fixed in svn.
--
Thomas

Revision history for this message

In Debian Bug tracker #342160, Thomas Hood (jdthood-yahoo) wrote on 2005-12-17: pending

#2

package initscripts sysv-rc sysvinit
tags 338801 pending
tags 338736 fixed-in-experimental
tags 342160 fixed-in-experimental
tags 342744 fixed-in-experimental
stop

Revision history for this message

In Debian Bug tracker #342160, Thomas Hood (jdthood-yahoo) wrote on 2006-01-06: Re: [Pkg-sysvinit-devel] Bug#346148: checkroot.sh: does not properly handle fsck exit states

#3

tags 346148 fixed-in-experimental patch pending
severity 342160 critical
merge 346148 342160
found 346148 2.86.ds1-4
stop

Wouter Verhelst wrote:
> I just noticed that my laptop, at bootup, started an fsck for the root
> filesystem, claiming that it was a filesystem with errors. When it was
> about 20% done, it exited, and told me to rerun it manually. I expected
> a prompt for my root password and to be put in single-user mode, but
> this did not happen; instead, my system did a normal boot.
>
> This should _never_ happen! If the fsck fails, all sorts of bad things
> might have happened with the file system; continueing the boot at that
> point is a very good way to lose all your data.

Thanks for reporting the bug.

checkroot.sh in at 2.86.ds1-[46] contains a bug such that the return status
of fsck is ignored. This bug has been fixed in more recent releases (to
experimental).

Additional info:

Reading checkroot.sh I see that it only continues with booting if the fsck
return status is 0 or 1. If the status is 2 or 3 then the system is rebooted
after five seconds. If the status is greater than 3 then a shell is started.

The comment in checkroot.sh says "A return code of 1 indicates that file system
errors were corrected but that the boot may proceed."

The fsck(8) and fsck.ext3(8) man pages say that 1 means "File system errors
corrected".
--
Thomas Hood

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2006-01-06: initscripts: checkroot.sh ignores fsck result

#4

Automatically imported from Debian bug report #342160 http://bugs.debian.org/342160

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2006-01-06:

#5

Message-Id: <E1EjO62-0002If-Ms@ei>
Date: Mon, 05 Dec 2005 16:42:05 -0500
From: Ilguiz Latypov <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: initscripts: checkroot.sh ignores fsck result

Package: initscripts
Version: 2.86.ds1-6
Severity: normal
Tags: patch

The /etc/init.d/checkroot.sh script ignored the fsck's "PLEASE REBOOT
LINUX NOW" exit code because the code is stored too late. As a result,
the fixes fsck made to my filesystem could be corrupted again because
the system didn't reboot immediately.

Besides, the if/then/else/fi statement's syntax was messed up.
Surprisingly, it was still valid according to "sh -n".

Here is the suggested patch.

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
--- checkroot.sh.orig 2005-11-19 06:40:50.000000000 -0500
+++ checkroot.sh 2005-12-05 16:35:34.000000000 -0500
@@ -249,12 +249,13 @@
                fi
                log_action_msg "Will now check root file system"
                fsck $spinner $force $fix -T -t $roottype $rootdev
- if [ "$?" = 0 ]
- log_success_msg "Done checking root file system"
+ FSCKCODE=$?
+ if [ "$FSCKCODE" = 0 ]
                then
+ log_success_msg "Done checking root file system"
+ else
                        log_failure_msg "Done checking root file system"
                fi
- FSCKCODE=$?
        fi

#
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (800, 'unstable')
Architecture: i386 (i686)
Shell: /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-2-k7
Locale: LANG=ru_RU.KOI8-R, LC_CTYPE=ru_RU.KOI8-R (charmap=KOI8-R)

Versions of packages initscripts depends on:
ii coreutils 5.93-5 The GNU core utilities
ii dpkg 1.13.11.0.1 package maintenance system for Deb
ii e2fsprogs 1.38-2 ext2 file system utilities and lib
ii libc6 2.3.5-8.1 GNU C Library: Shared libraries an
ii lsb-base 3.0-11 Linux Standard Base 3.0 init scrip
ii util-linux 2.12p-8 Miscellaneous system utilities

initscripts recommends no packages.

-- no debconf information

Message-Id: <E1EjO62-0002If-Ms@ei>
Date: Mon, 05 Dec 2005 16:42:05 -0500
From: Ilguiz Latypov <ilatypov@infradead.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: initscripts: checkroot.sh ignores fsck result

Package: initscripts
Version: 2.86.ds1-6
Severity: normal
Tags: patch

The /etc/init.d/checkroot.sh script ignored the fsck's "PLEASE REBOOT
LINUX NOW" exit code because the code is stored too late.  As a result,
the fixes fsck made to my filesystem could be corrupted again because
the system didn't reboot immediately.

Besides, the if/then/else/fi statement's syntax was messed up.
Surprisingly, it was still valid according to "sh -n".

Here is the suggested patch.

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
--- checkroot.sh.orig   2005-11-19 06:40:50.000000000 -0500
+++ checkroot.sh        2005-12-05 16:35:34.000000000 -0500
@@ -249,12 +249,13 @@
                fi
                log_action_msg "Will now check root file system"
                fsck $spinner $force $fix -T -t $roottype $rootdev
-               if [ "$?" = 0 ]
-                       log_success_msg "Done checking root file system"
+               FSCKCODE=$?
+               if [ "$FSCKCODE" = 0 ]
                then
+                       log_success_msg "Done checking root file system"
+               else
                        log_failure_msg "Done checking root file system"
                fi
-               FSCKCODE=$?
        fi
 
        #
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (800, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.14-2-k7
Locale: LANG=ru_RU.KOI8-R, LC_CTYPE=ru_RU.KOI8-R (charmap=KOI8-R)

Versions of packages initscripts depends on:
ii  coreutils                    5.93-5      The GNU core utilities
ii  dpkg                         1.13.11.0.1 package maintenance system for Deb
ii  e2fsprogs                    1.38-2      ext2 file system utilities and lib
ii  libc6                        2.3.5-8.1   GNU C Library: Shared libraries an
ii  lsb-base                     3.0-11      Linux Standard Base 3.0 init scrip
ii  util-linux                   2.12p-8     Miscellaneous system utilities

initscripts recommends no packages.

-- no debconf information

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2006-01-06:

#6

Message-ID: <email address hidden>
Date: Sat, 10 Dec 2005 18:36:41 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Subject: Re: checkroot.sh ignores fsck result

tags 342160 pending
stop

Ilguiz Latypov wrote:
> The /etc/init.d/checkroot.sh script ignored the fsck's "PLEASE REBOOT
> LINUX NOW" exit code because the code is stored too late.

Thanks for reporting this.

The bug has been fixed in svn.
--
Thomas

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2006-01-06:

#7

Message-ID: <email address hidden>
Date: Sun, 18 Dec 2005 00:10:29 +0100
From: Thomas Hood <email address hidden>
To: Debian Bug Tracking System <email address hidden>
Subject: pending

package initscripts sysv-rc sysvinit
tags 338801 pending
tags 338736 fixed-in-experimental
tags 342160 fixed-in-experimental
tags 342744 fixed-in-experimental
stop

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2006-01-06:

#8

Message-ID: <email address hidden>
Date: Fri, 06 Jan 2006 12:01:40 +0100
From: Thomas Hood <email address hidden>
To: <email address hidden>
Cc: <email address hidden>
Subject: Re: [Pkg-sysvinit-devel] Bug#346148: checkroot.sh: does not properly handle fsck exit states

tags 346148 fixed-in-experimental patch pending
severity 342160 critical
merge 346148 342160
found 346148 2.86.ds1-4
stop

Wouter Verhelst wrote:
> I just noticed that my laptop, at bootup, started an fsck for the root
> filesystem, claiming that it was a filesystem with errors. When it was
> about 20% done, it exited, and told me to rerun it manually. I expected
> a prompt for my root password and to be put in single-user mode, but
> this did not happen; instead, my system did a normal boot.
>
> This should _never_ happen! If the fsck fails, all sorts of bad things
> might have happened with the file system; continueing the boot at that
> point is a very good way to lose all your data.

Thanks for reporting the bug.

checkroot.sh in at 2.86.ds1-[46] contains a bug such that the return status
of fsck is ignored. This bug has been fixed in more recent releases (to
experimental).

Additional info:

Reading checkroot.sh I see that it only continues with booting if the fsck
return status is 0 or 1. If the status is 2 or 3 then the system is rebooted
after five seconds. If the status is greater than 3 then a shell is started.

The comment in checkroot.sh says "A return code of 1 indicates that file system
errors were corrected but that the boot may proceed."

The fsck(8) and fsck.ext3(8) man pages say that 1 means "File system errors
corrected".
--
Thomas Hood

Revision history for this message

Debian Bug Importer (debzilla) wrote on 2006-01-06:

#9

*** Bug 28053 has been marked as a duplicate of this bug. ***

Revision history for this message

In Debian Bug tracker #342160, Petter Reinholdtsen (pere-debian) wrote on 2006-01-22: Bug#342160: fixed in sysvinit 2.86.ds1-11

#10

Download full text (14.4 KiB)

Source: sysvinit
Source-Version: 2.86.ds1-11

We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive:

initscripts_2.86.ds1-11_i386.deb
  to pool/main/s/sysvinit/initscripts_2.86.ds1-11_i386.deb
sysv-rc_2.86.ds1-11_all.deb
  to pool/main/s/sysvinit/sysv-rc_2.86.ds1-11_all.deb
sysvinit_2.86.ds1-11.diff.gz
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-11.diff.gz
sysvinit_2.86.ds1-11.dsc
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-11.dsc
sysvinit_2.86.ds1-11_i386.deb
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-11_i386.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <email address hidden> (supplier of updated sysvinit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 22 Jan 2006 22:17:38 +0100
Source: sysvinit
Binary: sysv-rc sysvinit initscripts
Architecture: source i386 all
Version: 2.86.ds1-11
Distribution: unstable
Urgency: low
Maintainer: sysvinit maintainers <email address hidden>
Changed-By: Petter Reinholdtsen <email address hidden>
Description:
initscripts - Scripts for initializing and shutting down the system
sysv-rc - System-V-like runlevel change mechanism
sysvinit - System-V-like init utilities
Closes: 55143 89481 95390 116366 160329 186880 189356 213028 220025 227540 237074 238861 242957 258290 272066 275680 286082 286479 316423 323749 327865 328582 328764 330155 331397 332309 333836 336172 338736 338801 339023 339979 340017 341075 341097 342160 342744 343596 343862 343863 343993 344001 344089 344547 344547 345267 345269 345272 345273 345321 345370 345719 345968 346139 346415
Changes:
sysvinit (2.86.ds1-11) unstable; urgency=low
.
   [ Thomas Hood ]
   * rcS(5): Improve
   * sulogin(8): Improve; mention -t option (Closes: #186880)
   * bootlogd(8): Improve; mention need for PTY support
   * initscripts postinst: Update to reflect script name changes
   * initscripts: Harmonize PATH settings
   * checkroot.sh: Don't check for need to start /sbin/update.
     We don't support pre-2.4 kernels any more.
   * checkroot.sh, mountall.sh: Run swapon with -v if VERBOSE!=no
   * Remove obsolete lintian overrides
   * Previous release also
     closes: #258290 "bootlogd: Bad file descriptor"
     closes: #327865 "bootlogd stopped working"
     closes: #328764 "bootlogd fails to start"
.
   [ Petter Reinholdtsen ]
   * Time to upload all these changes into unstable (Closes: #341075)
   * Revert default VERBOSE value to "yes" to reduce the amount of
     user visible changes in this upload.
.
sysvinit (2.86.ds1-10) experimental; urgency=low
.
   [ Thomas Hood ]
   * bootclean: Adapt from old bootclean.sh; handle return status mor...

Source: sysvinit
Source-Version: 2.86.ds1-11

We believe that the bug you reported is fixed in the latest version of
sysvinit, which is due to be installed in the Debian FTP archive:

initscripts_2.86.ds1-11_i386.deb
  to pool/main/s/sysvinit/initscripts_2.86.ds1-11_i386.deb
sysv-rc_2.86.ds1-11_all.deb
  to pool/main/s/sysvinit/sysv-rc_2.86.ds1-11_all.deb
sysvinit_2.86.ds1-11.diff.gz
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-11.diff.gz
sysvinit_2.86.ds1-11.dsc
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-11.dsc
sysvinit_2.86.ds1-11_i386.deb
  to pool/main/s/sysvinit/sysvinit_2.86.ds1-11_i386.deb

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 342160@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated sysvinit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 22 Jan 2006 22:17:38 +0100
Source: sysvinit
Binary: sysv-rc sysvinit initscripts
Architecture: source i386 all
Version: 2.86.ds1-11
Distribution: unstable
Urgency: low
Maintainer: sysvinit maintainers <pkg-sysvinit-devel@lists.alioth.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description: 
 initscripts - Scripts for initializing and shutting down the system
 sysv-rc    - System-V-like runlevel change mechanism
 sysvinit   - System-V-like init utilities
Closes: 55143 89481 95390 116366 160329 186880 189356 213028 220025 227540 237074 238861 242957 258290 272066 275680 286082 286479 316423 323749 327865 328582 328764 330155 331397 332309 333836 336172 338736 338801 339023 339979 340017 341075 341097 342160 342744 343596 343862 343863 343993 344001 344089 344547 344547 345267 345269 345272 345273 345321 345370 345719 345968 346139 346415
Changes: 
 sysvinit (2.86.ds1-11) unstable; urgency=low
 .
   [ Thomas Hood ]
   * rcS(5): Improve
   * sulogin(8): Improve; mention -t option  (Closes: #186880)
   * bootlogd(8): Improve; mention need for PTY support
   * initscripts postinst: Update to reflect script name changes
   * initscripts: Harmonize PATH settings
   * checkroot.sh: Don't check for need to start /sbin/update.
     We don't support pre-2.4 kernels any more.
   * checkroot.sh, mountall.sh: Run swapon with -v if VERBOSE!=no
   * Remove obsolete lintian overrides
   * Previous release also
     closes: #258290 "bootlogd: Bad file descriptor"
     closes: #327865 "bootlogd stopped working"
     closes: #328764 "bootlogd fails to start"
 .
   [ Petter Reinholdtsen ]
   * Time to upload all these changes into unstable  (Closes: #341075)
   * Revert default VERBOSE value to "yes" to reduce the amount of
     user visible changes in this upload.
 .
 sysvinit (2.86.ds1-10) experimental; urgency=low
 .
   [ Thomas Hood ]
   * bootclean: Adapt from old bootclean.sh; handle return status more
     carefully; print diagnostic messages on failures; eliminate use of
     subshells; add comments; improve deletion code
   * bootclean: Always rm /tmp/.X*-lock
   * mountall.sh: Eliminate unnecessary check for pre-2.4 Linux kernel
   * mountnfs.sh, mountall.sh: Choose different names for intnl. functions
   * mountnfs.sh: Only sleep 1 second after starting portmap; note that
     the code to start portmap will disappear someday
   * various scripts: Make more messages depend on VERBOSE being != "no"
   * various scripts: Handle return status more carefully
   * various scripts: Eliminate unnecessary uses of subshell
   * mountvirtfs -> mountkernfs.sh; mountdevsubfs -> mountdevsubfs.sh;
     mountvirtfs now calls the above two (for backward compatibility);
     mtab.sh now runs mountkernfs.sh and mountdevsubfs.sh to update
     the mtab file after mountall.sh.
   * /etc/init.d/rc: Restore PATH after sourcing an initscript
   * debian/rules:
     + Use ':', not the deprecated '.' between owner and group names
       in chown commands
     + Use '-o root' with install
   * /etc/init.d/README: Note that /etc/init.d/*.sh must have '#!/bin/sh'
     and must follow policy 10.4.
   * Override lintian and linda warnings
 .
   [ Ubuntu backports by T.H. ]
   * During shutdown and reboot take the progress bar from 100 to 0
   * Reduce diff with 2.86.ds1-6ubuntu1
 .
   Thanks to Mark Hatle and Marco d'Itri for help with this release.
 .
 sysvinit (2.86.ds1-9) experimental; urgency=low
 .
   [ Thomas Hood ]
   * Split mountdevsubfs out of mountvirtfs and run it at S04 and S37.
     [Note added in 2.86.ds1-10: these scripts were renamed]
     This should not behave any differently, but the split will allow
     packages that futz with /dev to do this at S03.
   * umountfs: Only run umount if there is something to unmount
     (Closes: #345272)
   * urandom: Set PATH so that find can be found  (Closes: #345273)
   * init: 64_init_set_PATH.dpatch: Set PATH if it's unset on re-exec
     (Closes: #345370)
   * init: 65_init_u_in_06.dpatch: Allow 'telinit u' in runlevels 0, 6
     (Closes: #345719)  People running Debian from unusual media (such
     as filesystems embedded in NTFS files) are wanting to unmount
     /sbin at the last moment and need to re-exec init to do so.
   * umountroot: Remount ro with -f on GNU/kFreeBSD  (Closes: #344547)
   * checkroot.sh, checkfs.sh: Pause for five seconds if sulogin fails
     so that the user can see the error message  (Addresses #337444)
   * Include /var/log/fsck/ in initscripts package  (Closes: #346139)
   * Replace /lib/init/functions.sh with /lib/init/mount-functions.sh
     for use by mountvirtfs and mountdevsubfs
   * various initscripts: Clean up code that reads fstab
   * various scripts: Redirect which program's stderr to /dev/null
     since the GNU version prints an error message when the command is
     not found  (Closes: #345321)
   * /etc/default/rcS: Make VERBOSE and DELAYLOGIN default to "no"
   * /etc/default/rcS: Remove descriptions of variables; leave behind
     a reference to rcS(5).  This eliminates the problem of comments
     becoming outdated without our being able to update them.
   * Remove obsolete docs
   * Make initscripts Depend on mount >= 2.11x-1  (Closes: #345968)
   * Remove obsolete dependencies on bsdutils, coreutils, dpkg, kbd and
     util-linux: the versions in question are older than oldstable, so
     any newly installed system and any system that has upgraded to
     sarge (or even woody) satisfies the constraints.
   * Remove obsolete dependency on the last package: last was forced off
     systems when they upgraded to buzz
   * Add Replaces to Conflicts: mdutils which no longer exists even in
     oldstable
   * initscripts postinst: Remove obsolete GMT-to-UTC code: this
     conversion was performed when systems were upgraded to potato
   * sysvinit: Depend on libc6 rather than Pre-Depending on it; we don't
     do anything special in the preinsts any more
   * Correct documentation of init's -e and -t options
   * Tweak descriptions
   * Add READMEs for remaining runlevel dirs  (Closes: #242957)
   * Previous release also
     closes: #227540 "skeleton: Don't include /usr/local/* in PATH"
     closes: #346415 "mountnfs.sh doesn't work with the "bg" mount option"
 .
   [ Petter Reinholdtsen ]
   * sysv-rc: Fix some typos in the startpar handling.  (Closes: #345269)
   * Add code to detect and report bad 'exit' calls in init.d scripts,
     if they kill /etc/init.d/rc.
   * Make sure sourcing work with dash /bin/sh, by using 'set $action'
     to pass arguments to the script. (Closes: #345267)
 .
   Thanks to Mark Hatle for help with this release.
 .
 sysvinit (2.86.ds1-8) experimental; urgency=low
 .
   [ Thomas Hood ]
   * Omit /run until we are sure it's needed  (Closes: #344001)
   * Previous release also
     closes: #338736 "mountvirtfs: Succeeds in various cases it should fail"
     closes: #342160 "checkroot.sh ignores fsck result"
     closes: #342744 "checkroot.sh sources mountvirtfs, yet supplies arguments"
   * Use /proc/mounts instead of /etc/mtab when unmounting  (Closes: #338801)
   * Check for files under mountpoints more thoroughly
   * initscripts.postinst:
     + Don't fail to install on file-rc systems  (Closes: #343993)
     + Don't fail to install in chroots  (Closes: #344089)
   * No longer keep the dynamic nologin flag file on the root filesystem;
     instead, keep it at /var/lib/initscripts/nologin.  Note to admins:
     initscripts's postinst symlinks /etc/nologin to the latter location.
     To switch login delaying on or off permanently, set DELAYLOGIN=no in
     /etc/default/rcS and either create or delete (respectively)
     /var/lib/initscripts/nologin.
   * mountvirtfs: Mount /dev/shm earlier; move long comment to README.Debian
   * Add 45_pidof_symlink.dpatch: Make pidof an absolute symlink
     (Closes: #343862)
   * debian/rules, 30_strip.dpatch: Strip .comment section from executables
     (Closes: #343863)
   * In umountfs, run umount with -f  (Closes: #344547)
 .
   [ Petter Reinholdtsen ]
   * Enable the startpar option as it should work now that .sh scripts
     are serialized.  The clock should no longer jump while startpar
     is used.
 .
 sysvinit (2.86.ds1-7) experimental; urgency=low
 .
   [ Petter Reinholdtsen ]
   * Add commented-out code to /etc/init.d/rc for sourcing
     *.sh scripts for runlevel 'S'.  This is preparation for fixing
     #339955.  Actually fixing it has to wait until other packages
     remove "exit" from their .sh scripts.
   * Implement progress bar support for splash screen.  Enabled when
     usplash_write is in PATH.  Patch from Scott James Remnant and Ubuntu.
 .
   [ Thomas Hood ]
   * *.sh: Make sure that these do their thing when they aren't given any
     command line arguments (as is the case when they are sourced)
   * initscripts: Improve use of log_* functions
     (Closes: #55143, #116366, #323749)
   * bootclean.sh: Do not delete symlinks-to-directories from /var/run/
     (Closes: #272066)
   * checkroot.sh: Fix double printing of 'Done checking root file system';
     mountall.sh: Fix chopped-up printing of mount information
     (Closes: #339979, #331397, #341097 and presumably closes: #332309)
   * checkroot.sh, checkfs.sh: Save fsck logs  (Closes: #189356)
     Thanks to Theodore Y. Ts'o.
   * checkroot.sh, mountvirtfs: Eliminate use of dir_writable in order to
     try to please selinux  (Closes: #333836)
   * checkroot.sh: Only run findfs for mount on /  (Closes: #275680)
     Thanks to Cameron Hutchison for the patch.
   * mountall.sh, mountnfs.sh: Split call to bootclean out into separate
     script called at the next sequence number  (Closes: #286479)
   * bootmisc.sh: Shorten motd header  (Closes: #340017)
   * bootmisc.sh: Store dynamic motd in /var/run/ and make /etc/motd a
     symbolic link.  The EDITMOTD variable no longer has any effect; to
     disable updating of the motd just point the /etc/motd symlink to a
     static file such as /etc/motd.static.
   * bootmisc.sh: Rotate dmesg log with savelog (Closes: #237074)
     and chgrp adm.
   * umountroot: Change mount command in order to exclude bind mounts of
     the root directory  (Closes: #339023)
   * Replace /etc/rc1.d/20single by /etc/rc1.d/S30killprocs and
     /etc/rc1.d/S99single so that packages can insert scripts to do
     things between the "killall5" in the former and the "exec init -t1 S"
     in the latter.  This may help to address #145280.
   * umountfs: Unmount tmpfs before swapoff and other fs's afterwards
     (Closes: #328582, hopefully without reopening #84782)
   * Make stop-bootlogd a distinct script rather than a symlink to bootlogd.
     Give it its own LSB header.
   * Add stop-bootlogd-single initscript to stop bootlogd in "single" mode
     (Closes: #213028, #220025)
   * checkfs.sh: Implement FSCKTYPES  (Closes: #89481)  Set, e.g.,
     FSCKTYPES="ext2,msdos" to fsck only file system types ext2 and msdos
     See fsck(8) for syntax.  FSCKTYPES="none" disables fsck of file
     systems (other than the root filesystem) altogether.
   * all initscripts: Set variables using common script
   * all initscripts: Fix usage messages
   * all initscripts: Allow VERBOSE to be set via the INIT_VERBOSE=yes
     kernel argument (Closes: #286082)  Experimental.  The name of the
     kernel argument may change in the future if we decide to implement
     this more generally.
   * Improve skeleton initscript
   * all scripts: Clean up; standardize indentation
   * all scripts: Use the "which" program to test for executability
   * initscripts: Experimentally include /run; include /sys in Linux
     builds
   * mountvirtfs: Mount a tmpfs on /run
   * mountvirtfs: Warn if mount point has stuff under it (Closes: #95390)
   * initscripts postinst: Mount virtual filesystems
   * initscripts preinst: Remove ancient /etc/init.d/boot conversion code
     (Closes: #343596)
   * default config files: Clean up comments
   * Make initscripts Depend on debianutils >= 2.13.1 in order to prevent
     #295850.  Note that debianutils also has to be >= 2.12.0 so that the
     "which" program is available in /bin.
   * Remove currently unneeded sysvinit Dependency on coreutils
     (Closes: #316423)
   * pidof: If the program is specified with a path, don't match processes
     of programs run from different paths  (Closes: #160329)
   * init: 40_selinux.dpatch: Remove superfluous printf argument
   * init: Add 63_init_longer_procname.dpatch  (Closes: #336172)
   * init.8: Mention that entering runlevel 1 kills all processes
     (Closes: #238861)
   * update-rc.d.8: Mention that update-rc.d will not create multiple start
     or multiple stop symlinks for a service in a single runlevel directory.
     (Closes: #330155)
   * Update FSF address
Files: 
 cca49f73a985dcc6fbf0410c3243cd14 848 admin required sysvinit_2.86.ds1-11.dsc
 7f26e6d72c29a20b3d0381a97141c21f 112802 admin required sysvinit_2.86.ds1-11.diff.gz
 801a25967fb00c616db597a464064b53 119464 admin required sysvinit_2.86.ds1-11_i386.deb
 01c5f33796185256906158ad4c967bb0 46656 admin required initscripts_2.86.ds1-11_i386.deb
 fe08677435abe9791026ad3ba4a095c6 46108 admin required sysv-rc_2.86.ds1-11_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFD0/h620zMSyow1ykRAkd0AJ9kv8MVXNUW6zYBQFSSq7rWyQYFIgCggc9E
i3nBoAmC80NrkOq2Kcm6Xvc=
=/H8P
-----END PGP SIGNATURE-----

Revision history for this message

Tormod Volden (tormodvolden) wrote on 2006-02-17: Re: initscripts: checkroot.sh ignores fsck result

#11

Can confirm this on dapper up to date. "/ contains a file system with errors, check forced. Inodes... /: UNEXPECTED INCONSISTENCY; RUN fsck MANUALLY" but then it just goes on with "done checking file system" (twice). And the same happens at the next boot, so clearly nothing was fixed by itself.

Changed in sysvinit:
status:	Unconfirmed → Confirmed

Revision history for this message

Tormod Volden (tormodvolden) wrote on 2006-03-17:

#12

> Reading checkroot.sh I see that it only continues with booting if the fsck
return status is 0 or 1.

AFAICS this is wrong. The return status is lost after the log_failure_msg call anyway, so the script always think everything went well.

Revision history for this message

Tormod Volden (tormodvolden) wrote on 2006-03-17: fixes the ignored return status from fsck

#13

fixes the ignored return status from fsck Edit (512 bytes, text/plain)

Please accept this humble patch. This little cleanup fixes the problem and can help avoid bad longtime fs corruption.

Revision history for this message

Tormod Volden (tormodvolden) wrote on 2006-03-17:

#14

This can cause dataloss. It is fixed upstream, but not in dapper.

Revision history for this message

Scott James Remnant (Canonical) (canonical-scott) wrote on 2006-03-21:

#15

Fixed in dapper now.

Changed in sysvinit:
status:	Unconfirmed → Fix Released
status:	Confirmed → Fix Released

Affects		Status	Importance	Assigned to	Milestone
	sysvinit (Debian)	Fix Released	Unknown	debbugs #342160
	sysvinit (Ubuntu)	Fix Released	Critical	Unassigned

Ubuntu
sysvinit package

[PATCH] initscripts: checkroot.sh ignores fsck result

Bug Description

Duplicates of this bug

Other bug subscribers

Patches

Remote bug watches

Ubuntusysvinit package

[PATCH] initscripts: checkroot.sh ignores fsck result

Bug Description

Duplicates of this bug

Other bug subscribers

Patches

Remote bug watches

Ubuntu
sysvinit package