Missing include file taskmanager/taskmanager_export.h

[Martin von Gagern]

Binary package hint: kdebase-workspace-dev

This is an issue with the header files installed in several kde development packages in intrepid.

The header files taskmanager/task.h taskmanager/taskmanager.h from kdebase-workspace-dev 4:4.1.2-0ubuntu5 reference a header file called taskmanager/taskmanager_export.h which is not installed with the package.

Building the package from source, there is no reference to this file, and some other headers are included as "startup.h" and "task.h" instead of <taskmanager/startup.h> and <taskmanager/task.h>. So something seems to modify this header in the official package that doesn't do so when I build it from source. Strange.

There are several other packages on my system showing similar issues, i.e. mentioning *_export.h header files which are not available. Those packages are kdelibs5-dev, kdepimlibs5-dev and libplasma-dev. This list probably isn't exhaustive, as I don't have all KDE dev packages installed. Should I report separate bugs for each of these, or rather mark this bug here as affecting those as well?

[Harald Sitter (apachelogger)]

I doubt that this does not happen when building from source.
http://websvn.kde.org/branches/KDE/4.1/kdebase/workspace/libs/taskmanager/CMakeLists.txt?revision=829867&view=markup
Note the last line.

Anyway, please report individual bugs, but at the KDE bug tracker http://bugs.kde.org these things should be fixed in KDE, and KDE only, anything else would make Kubuntu's behavior differ too much from KDE.

[Martin von Gagern (gagern)]

> I doubt that this does not happen when building from source.

Do you doubt my word? To clarify: the problem didn't happen here, not because the taskmanager_export.h got installed (which wasn't the case), but because taskmanager.h no longer refered to it. In that sense, the summary of this bug mentioning a "missing file" is only a problem description, I don't wish to express that the issue should be fixed by providing such a file.

Steps to reproduce:
1. sudo apt-get build-dep kdebase-workspace-dev
2. apt-get source kdebase-workspace-dev
3. cd kdebase-workspace-4.1.2
4. dpkg-buildpackage -rfakeroot -uc -b
5. cd ..
6. dpkg-deb -x kdebase-workspace-dev_4.1.2-0ubuntu1_i386.deb myDev
7. diff -U1 {,myDev}/usr/include/taskmanager/taskmanager.h

--- /usr/include/taskmanager/taskmanager.h
+++ dev1/usr/include/taskmanager/taskmanager.h
@@ -28,5 +28,4 @@
 // Own
-#include <taskmanager/startup.h>
-#include <taskmanager/task.h>
-#include <taskmanager/taskmanager_export.h>
+#include "startup.h"
+#include "task.h"

@@ -43,3 +42,3 @@
  */
-class TASKMANAGER_EXPORT TaskManager : public QObject
+class KDE_EXPORT TaskManager : public QObject
 {

> [...] taskmanager/CMakeLists.txt [...]
> Note the last line.

Tells me that some file called taskmanager.h gets installed, and probably no taskmanager_export.h. Doesn't say a word about whether or not the taskmanager.h references a taskmanager_export.h or not. For that see the source of the header: http://websvn.kde.org/branches/KDE/4.1/kdebase/workspace/libs/taskmanager/taskmanager.h?view=markup

> Anyway, please report individual bugs

I'll report the others seperately once this here is done, to avoid redundant discussion.

> But at the KDE bug tracker http://bugs.kde.org these things should
> be fixed in KDE, and KDE only, anything else would make Kubuntu's
> behavior differ too much from KDE.

To report this upstream I'd have to explain how KDE is to blame for the ubuntu package containing a file so different from the one shipped with the KDE sources. As I can't even reproduce this different file, I think it unlikely that the cause lies somewhere in the KDE managed code. Unless you convince me otherwise, I'll consider this an Ubuntu bug.

Right now, the issue looks to me as if the ubuntu packager had slipped some modified header file into the package at some point during the packaging process, without any reference in the rules file or anywhere wlse in the debian directory. As the taskmanager.h in the source tree stays unmodified during the build, and no taskmanager_export.h seems to get generated, I cannot account for this file in any other way. But I'm not that experienced in either Debian packaging or KDE development, so maybe there is some way I didn't know about, which does such modifications but won't affect my local builds.

[Harald Sitter (apachelogger)]

Ok, now I understood.
And indeed you are right, the broken includes are created by a patch (yet again). However I doubt that the _export.h in libs and pimlibs are wrong (or caused by us), would be nice if you could check that.

As for the plasma affect I am assigning Jonathan Thomas since he did the implementation. This issue should be fixed ASAP due to the very same reasons I wanted to not fix this issue.

[Martin von Gagern (gagern)]

> However I doubt that the _export.h in libs and pimlibs are wrong (or caused by us), would be nice if you could check that.

Bug in my check script - been searching for file names ending in newline... libplasma-dev was a false alarm as well, so that taskmanager.h remains the only real issue.

[Harald Sitter (apachelogger)]

Ok. Thank you very much.

[Jonathan Thomas (echidnaman)]

This bug was fixed in:
kdebase-workspace (4:4.1.2-0ubuntu6) intrepid; urgency=low

  [ Jonathan Thomas ]
  * Revert trunk changes to taskmanager.h includes in
    kubuntu_20_plasma_tooltips.diff.
  * Add taskmanager_exports.h to kdebase-workspace-dev.install.
  * Include the ToolTipManager includes/headers to libplasma-dev.install.

  [ Harald Sitter ]
  * Add pam files for kscreensaver and kcheckpass (LP: #278842)
  * Remove kubuntu_09_kickoff_favourites.diff in favor of kickoffrc in k-d-s

 -- Harald Sitter < <email address hidden>> Tue, 07 Oct 2008 22:14:09 +0200

Sorry for the trouble. ;-)