plone.org references in plone.css

Bug #275 reported by Brad Bollenbach
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Matthew Paul Thomas

Bug Description

There are a bunch of places in plone.css that are still hitting plone.org, e.g.

.contentActions li {
    float: right;
    background-image: url(http://plone.org/arrowDownAlternative.gif);
    background-repeat: no-repeat;
    background-position: center right;
    z-index: 4;
    border-left: 1px solid #74ae0b;
    padding: 0 0 0 1em;
    margin: 0 1em 0 0;
}

These references to plone.org should be removed.

Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

I think the ideais to leave plone.css exactly as it comes from plone.org, then use launchpad.css to override it. If there is an image ref in plone.css which refers to plone.org and is NOT being overridden in launchpad.css then it is a bug, but the fix is not to edit plone.css, but to update launchpad.css to override plone.css.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I'm happy with overriding plone.css in the "Fix plone.css bugs" section of launchpad.css. (The proper fix is for the Plone people to change all non-comment occurrences of "http://plone.org/" to "/" in plone.css. That would Do The Right Thing for every Plone site.)

But I can't fix it until the images in launchpad/images/ are made accessible to Launchpad. For example, <http://plone.org/info_icon.gif> works, but <http://localhost:8086/info_icon.gif> doesn't (nor <http://launchpad.ubuntu.com/info_icon.gif>). Why?

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Oh, it's /@@/info_icon.gif etc. According to <<email address hidden>/launchpad--apidoc-access--0--patch-2>, this is "the Z3 preferred spelling (/@@/foo.png instead of /++resource++foo.png)". (I suppose /foo.png would be too simple.)

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I've fixed most of these now; I can't do the rest because /@@/whatever doesn't work for some of the launchpad/images/ and I don't know why. (For example, /@@/linkTransparent.gif works but /@@/linkOpaque.gif doesn't.)

Revision history for this message
Christian Reis (kiko) wrote :

Matthew, if you like, we can go over the remaining issues together and fix this once and for all.

Changed in launchpad:
assignee: nobody → mpt
status: New → PendingUpload
Changed in launchpad:
status: PendingUpload → Fixed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.