Components that implement clean() should call their parents' clean() using super().

[Guillaume Emont]

You can find them them using pylint (as in 'aptitude install pylint') and a
checker I wrote, that you can find in tools/checker on the branch at
lp:~guijemont/elisa/memory_tools. Very basic instructions on how to use
that are provided at the beginning of the python file.
Note that the checker is not perfect and might have false positives.

[Alessandro Decina (alessandro.decina)]

I would do an exceptions for components that inherit directly from Component though.
Component.clean returns a defer.succeed(self), so calling it doesn't add any value
and only makes the code less readable.

[Alessandro Decina (alessandro.decina)]

You pushed the changes already. Oh well.

[Guillaume Emont (guijemont)]

I think we need to do super(Blah, self).clean() everywhere we reimplement clean(), with no exception, else we end up with clean() implementations not called where we have diamond inheritance. (the super().clean() does more than calling the parent's clean, it is used to call a brother's clean as well).

[Guillaume Emont (guijemont)]

On a fait une release sans me dire ? Le fix a été mergé aujourd'hui
(jeudi 25 septembre)...

Guillaume

Le jeudi 25 septembre 2008 à 17:19 +0000, yyoyo a écrit :
> ** Changed in: elisa
> Status: Fix Committed => Fix Released
>