Components that implement clean() should call their parents' clean() using super().
Bug #274333 reported by
Guillaume Emont
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Moovida |
Fix Released
|
Undecided
|
Guillaume Emont |
Bug Description
You can find them them using pylint (as in 'aptitude install pylint') and a
checker I wrote, that you can find in tools/checker on the branch at
lp:~guijemont/elisa/memory_tools. Very basic instructions on how to use
that are provided at the beginning of the python file.
Note that the checker is not perfect and might have false positives.
Related branches
Changed in elisa: | |
assignee: | nobody → guijemont |
milestone: | none → 0.5.11 |
status: | New → In Progress |
status: | In Progress → Fix Committed |
Changed in elisa: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I would do an exceptions for components that inherit directly from Component though. self), so calling it doesn't add any value
Component.clean returns a defer.succeed(
and only makes the code less readable.