Consolidate the six views relating to upstream linking
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Edwin Grubbs |
Bug Description
There are currently at least six views relating to DistroSeriesSou
- <DSSP>/
- <DSSP>/+packaging
- <Product>/+packages
- <Product>
- <ProductSeries>
- <ProductSeries>
Yes, that is actually six views for a total of two actions. The information presented by each set of instances of the two page types should be the same, but differs significantly in both amount and display mode. The permissions on +ubuntupkg and +addpackage also differ.
There are at least five different manners of identifying a distroseries in use on these pages: "8.04 (Hardy)" , "8.04 (hardy)", "Hardy", "hardy", "The Hardy Heron". The unfriendly name "ubuntu" is also used in some places.
Bits of the data model are also exposed in just a single place, with no other place on Launchpad showing that part of the schema (that I can find): +addpackage has a <select> allowing me to specify whether it is the primary product in the sourcepackage or not, and +ubuntupkg gives a timestamp and attribution for the link.
The various pages occasionally refer to distroseries as releases, productseries as branches, upstream links as "Packaging Records" and "packages", and probably lots of other strange things.
Some inputs want "Source Package Names", others want "Source packages". Some inputs seem to be backed by JavaScripty vocabularies, while others of the same type are not. +distributions directs me to go and find a link that doesn't exist any more, when instead it could actually give me the link like +packages does. ProductSeries are occasionally referred to as "Some Product Series: trunk", which is a bit strange.
+packaging speaks of Feisty as a version, when it is in fact a series. It also says it's showing links for Ubuntu Intrepid soundconverter (maybe it means "soundconverter source package in Ubuntu"?), but then proceeds to show me all Ubuntu series, and even adds Ubuntu to each row of the table. It speaks of 'all source packages called "soundconverter"'. There is only one!
+distributions also speaks of an upstream series... the product owns this page, and products have no upstream!
The pages also show obsolete distroseries, which is useless because they don't contain any published versions any more, and the list is going to grow forever.
It is left as an exercise for the reader to work out how these pages should be merged, and to pick up other issues. Annotated screenshots of the current trainwrecks will come soon, showing a superset of the issues identified here.
See also bug 276412, bug 276417, and bug 276425.
Related branches
- Paul Hummer (community): Approve
-
Diff: 605 lines (+134/-280)12 files modifiedlib/canonical/launchpad/pagetests/basics/notfound-traversals.txt (+0/-1)
lib/lp/answers/templates/question-portlet-details.pt (+4/-4)
lib/lp/registry/browser/configure.zcml (+0/-7)
lib/lp/registry/browser/sourcepackage.py (+1/-14)
lib/lp/registry/interfaces/person.py (+6/-6)
lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt (+50/-127)
lib/lp/registry/templates/distroseries-index.pt (+1/-3)
lib/lp/registry/templates/distroseries-packaging.pt (+36/-31)
lib/lp/registry/templates/sourcepackage-index.pt (+27/-21)
lib/lp/registry/templates/sourcepackage-packaging.pt (+0/-62)
lib/lp/soyuz/stories/soyuz/xx-distroseries-index.txt (+2/-2)
lib/lp/soyuz/templates/distroseries-portlet-latestuploads.pt (+7/-2)
- Curtis Hovey (community): Approve
-
Diff: 552 lines (+104/-215)7 files modifiedlib/canonical/launchpad/pagetests/basics/notfound-traversals.txt (+0/-1)
lib/canonical/launchpad/webapp/menu.py (+6/-1)
lib/lp/registry/browser/configure.zcml (+0/-7)
lib/lp/registry/browser/packaging.py (+1/-76)
lib/lp/registry/browser/productseries.py (+61/-15)
lib/lp/registry/browser/tests/packaging-views.txt (+36/-72)
lib/lp/registry/templates/productseries-packaging.pt (+0/-43)
description: | updated |
affects: | launchpad-foundations → launchpad-registry |
Changed in launchpad-registry: | |
importance: | Undecided → Low |
status: | New → Triaged |
Changed in launchpad-registry: | |
milestone: | none → 3.1.12 |
Changed in launchpad-registry: | |
importance: | Low → High |
summary: |
- All six views relating to upstream linking are - broken/different/inconsistent/strange/outdated/unmaintained + Consolidate the six views relating to upstream linking |
Changed in launchpad-registry: | |
milestone: | 3.1.12 → 3.1.13 |
Changed in launchpad-registry: | |
assignee: | nobody → Edwin Grubbs (edwin-grubbs) |
status: | Triaged → In Progress |
Changed in launchpad-registry: | |
status: | In Progress → Fix Committed |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
While we're at it, <DSP>/+index needs to use proper delete buttons like the rest of LP.