Consolidate the six views relating to upstream linking

Bug #272343 reported by William Grant
10
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Edwin Grubbs

Bug Description

There are currently at least six views relating to DistroSeriesSourcePackage<->ProductSeries links (not including the overview on SP pages):
 - <DSSP>/+edit-packaging
 - <DSSP>/+packaging
 - <Product>/+packages
 - <Product>/+distributions
 - <ProductSeries>/+ubuntupkg
 - <ProductSeries>/+addpackage

Yes, that is actually six views for a total of two actions. The information presented by each set of instances of the two page types should be the same, but differs significantly in both amount and display mode. The permissions on +ubuntupkg and +addpackage also differ.

There are at least five different manners of identifying a distroseries in use on these pages: "8.04 (Hardy)" , "8.04 (hardy)", "Hardy", "hardy", "The Hardy Heron". The unfriendly name "ubuntu" is also used in some places.

Bits of the data model are also exposed in just a single place, with no other place on Launchpad showing that part of the schema (that I can find): +addpackage has a <select> allowing me to specify whether it is the primary product in the sourcepackage or not, and +ubuntupkg gives a timestamp and attribution for the link.

The various pages occasionally refer to distroseries as releases, productseries as branches, upstream links as "Packaging Records" and "packages", and probably lots of other strange things.

Some inputs want "Source Package Names", others want "Source packages". Some inputs seem to be backed by JavaScripty vocabularies, while others of the same type are not. +distributions directs me to go and find a link that doesn't exist any more, when instead it could actually give me the link like +packages does. ProductSeries are occasionally referred to as "Some Product Series: trunk", which is a bit strange.

+packaging speaks of Feisty as a version, when it is in fact a series. It also says it's showing links for Ubuntu Intrepid soundconverter (maybe it means "soundconverter source package in Ubuntu"?), but then proceeds to show me all Ubuntu series, and even adds Ubuntu to each row of the table. It speaks of 'all source packages called "soundconverter"'. There is only one!

+distributions also speaks of an upstream series... the product owns this page, and products have no upstream!

The pages also show obsolete distroseries, which is useless because they don't contain any published versions any more, and the list is going to grow forever.

It is left as an exercise for the reader to work out how these pages should be merged, and to pick up other issues. Annotated screenshots of the current trainwrecks will come soon, showing a superset of the issues identified here.

See also bug 276412, bug 276417, and bug 276425.

Related branches

Revision history for this message
William Grant (wgrant) wrote :
Revision history for this message
William Grant (wgrant) wrote :
Revision history for this message
William Grant (wgrant) wrote :
Revision history for this message
William Grant (wgrant) wrote :
Revision history for this message
William Grant (wgrant) wrote :
Revision history for this message
William Grant (wgrant) wrote :
Revision history for this message
William Grant (wgrant) wrote :

While we're at it, <DSP>/+index needs to use proper delete buttons like the rest of LP.

description: updated
Curtis Hovey (sinzui)
affects: launchpad-foundations → launchpad-registry
Changed in launchpad-registry:
importance: Undecided → Low
status: New → Triaged
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 3.1.12
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Low → High
Curtis Hovey (sinzui)
summary: - All six views relating to upstream linking are
- broken/different/inconsistent/strange/outdated/unmaintained
+ Consolidate the six views relating to upstream linking
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: 3.1.12 → 3.1.13
Changed in launchpad-registry:
assignee: nobody → Edwin Grubbs (edwin-grubbs)
status: Triaged → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

All the views are consolidated in the UI. packaging.PackagingAddView (+addpackage) code and test need to be removed to close this bug. We cannot remove the whole view though because ProductSeries.ProductSeriesUbuntuPackagingView (+ubuntupkg) is dervied from packaging.PackagingAddView.

lp/registry/browser/test/packaging-views.txt requries a rewrite because +addpackage is used to test some of the behaviour of the that +ubuntupkg hides from the user. One option is to register +addpackage only for the test layer (or register it in the test) so that the test is preserved, but users cannot access it.

Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in launchpad-registry:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.