better styles/resources fallback support
Bug #271801 reported by
Philippe Normand
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Moovida |
Fix Released
|
Undecided
|
Philippe Normand |
Bug Description
With current upicek:
1. Create a plugin containing a new styles.conf
2. Use it as frontend theme
3. Elisa doesn't start.
Because one of the poblesec resources "module_name" doesn't exist as a valid python module path (it's one of the control ribbon glyphes). And because resources lookup is kinda based on that, the Theme fails to load the resources.conf located at that wrong location.
Needs further investigation. Maybe merge fallback themes all together aside from the default theme. This solution would also be more reliable speed-wise.
Changed in elisa: | |
milestone: | none → 0.5.x |
Changed in elisa: | |
assignee: | nobody → philn |
milestone: | 0.5.x → 0.5.11 |
status: | New → Fix Committed |
Changed in elisa: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Merging fallback themes doesn't work. The first non-existing paths I see before Elisa crashes are:
- elisa.plugins. poblesec. player. back_button poblesec. player. ribbon
- elisa.plugins.
So, either we fix the resources paths or every time a Theme is created we merge it with the default Theme instance