test for non-existence of stacked on branch in mirrored area is bogus

Bug #270757 reported by Michael Hudson-Doyle
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jonathan Lange

Bug Description

For reasons that neither of us remember, we test for the non-existence of a stacked-on branch like this:

            stacked_on_branch_url = urlutils.join(
                self.dest, stacked_on_branch_url)
            if not get_transport(stacked_on_branch_url).has('.'):
                raise StackedOnBranchNotFound()

One problem with this, which is what triggered the report, is that it doesn't handle redirects.

However, it's also bogus because the directory existing doesn't necessarily mean there's a branch there -- and in particular, for our transport as soon as you ask the question, the directory is probably created (this is a separate issue that needs fixing by itself though).

Tags: lp-code
Jonathan Lange (jml)
Changed in launchpad-bazaar:
assignee: nobody → jml
importance: Undecided → High
milestone: none → 2.1.10
status: New → Triaged
milestone: 2.1.10 → none
Revision history for this message
Jonathan Lange (jml) wrote :

The patch for this has been reviewed. Not sure if it's release-critical.

Changed in launchpad-bazaar:
status: Triaged → In Progress
Revision history for this message
Jonathan Lange (jml) wrote :

Ready to land once release-critical is done.

Changed in launchpad-bazaar:
milestone: none → 2.1.10
Revision history for this message
Jonathan Lange (jml) wrote :

RF 7048

Changed in launchpad-bazaar:
status: In Progress → Fix Committed
Jonathan Lange (jml)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.