test for non-existence of stacked on branch in mirrored area is bogus
Bug #270757 reported by
Michael Hudson-Doyle
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jonathan Lange |
Bug Description
For reasons that neither of us remember, we test for the non-existence of a stacked-on branch like this:
if not get_transport(
One problem with this, which is what triggered the report, is that it doesn't handle redirects.
However, it's also bogus because the directory existing doesn't necessarily mean there's a branch there -- and in particular, for our transport as soon as you ask the question, the directory is probably created (this is a separate issue that needs fixing by itself though).
Changed in launchpad-bazaar: | |
assignee: | nobody → jml |
importance: | Undecided → High |
milestone: | none → 2.1.10 |
status: | New → Triaged |
milestone: | 2.1.10 → none |
Changed in launchpad-bazaar: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The patch for this has been reviewed. Not sure if it's release-critical.