[intrepid] olive-gtk crashed with ImportError in commit() due to a relative import

[Petr E. Antonov]

Binary package hint: bzr-gtk

Crashed when click Branch -> Update

ProblemType: Crash
Architecture: i386
DistroRelease: Ubuntu 8.10
ExecutablePath: /usr/bin/olive-gtk
InterpreterPath: /usr/bin/python2.5
Package: bzr-gtk 0.95.0-1ubuntu2
PackageArchitecture: all
ProcAttrCurrent: unconfined
ProcCmdline: /usr/bin/python /usr/bin/olive-gtk
ProcEnviron:
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
 LANG=ru_RU.UTF-8
 SHELL=/bin/bash
PythonArgs: ['/usr/bin/olive-gtk']
SourcePackage: bzr-gtk
Title: olive-gtk crashed with ImportError in commit()
Traceback:
 Traceback (most recent call last):
   File "/usr/lib/python2.5/site-packages/bzrlib/plugins/gtk/olive/menu.py", line 285, in commit
     from commit import CommitDialog
 ImportError: No module named commit
Uname: Linux 2.6.27-3-generic i686
UserGroups: adm admin audio cdrom dialout dip floppy fuse lpadmin plugdev video

[Andrea Corbellini (andrea.corbellini)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. You reported this bug a while ago and there hasn't been any activity in it recently. We were wondering if this is still an issue for you. Can you try with the latest Ubuntu release? Thanks in advance.

[Jasper Groenewegen (colbrac)]

Can't reproduce in my bzr-gtk but that's inside my homedir bzr plugins folder. I notice that in olive/menu.py there are several dialogs still imported relativily, e.g. 'from commit import CommitDialog' on line 285 and 'from bookmark import BookmarkDialog' on line 331.

Yet, for example the GAnnotateWindow and DiffWindow are imported at the top of menu.py. I'd assume either all or none of the dialogs should be imported at the top of menu.py. I'm not sure how early importing at the top will influence performance.

In any case, I think to fix this bug on line 285 'from commit' should be changed into 'from bzrlib.plugins.gtk.commit' and 'from bookmark' into 'from bzrlib.plugins.gtk.olive.bookmark'.

And no, I don't have time to do it properly right now. :)

[Emanuel Steen (kozz)]

Debdiff for the commit dialog

[Jamin W. Collins (jcollins)]

This is definitely still a problem in Ubuntu Karmic (9.10)