EggTexture not recognizing mirror(_once) ?

Bug #268586 reported by rdb
2
Affects Status Importance Assigned to Milestone
Panda3D
Fix Released
Undecided
Unassigned

Bug Description

I (by accident) stumbled on this piece of code in the Panda3D cvs:
////////////////////////////////////////////////////////////////////
// Function: EggTexture::string_wrap_mode
// Access: Published, Static
// Description: Returns the WrapMode value associated with the given
// string representation, or WM_unspecified if the string
// does not match any known WrapMode value.
////////////////////////////////////////////////////////////////////
EggTexture::WrapMode EggTexture::
string_wrap_mode(const string &string) {
  if (cmp_nocase_uh(string, "repeat") == 0) {
    return WM_repeat;
  } else if (cmp_nocase_uh(string, "clamp") == 0) {
    return WM_clamp;
  } else if (cmp_nocase_uh(string, "mirror") == 0) {
    return WM_clamp;
  } else if (cmp_nocase_uh(string, "mirror_once") == 0) {
    return WM_clamp;
  } else if (cmp_nocase_uh(string, "border_color") == 0) {
    return WM_border_color;
  } else {
    return WM_unspecified;
  }
}

Shouldn't it be WM_mirror when it's "mirror" and WM_mirror_once when it's "mirror_once", or was this done intentionally?

Revision history for this message
rdb (rdb) wrote :

Fixed by drwr:
http://panda3d.org/phpbb2/viewtopic.php?p=27042#27042
Probably will be in 1.6.0.

Changed in panda3d:
status: New → Fix Committed
rdb (rdb)
Changed in panda3d:
milestone: none → 1.5.4
rdb (rdb)
Changed in panda3d:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.