Ubuntu
scratchbox2 package

hardening patch needs to handle failure

Bug #267594 reported by Kees Cook
2
Affects Status Importance Assigned to Milestone
scratchbox2 (Ubuntu)
New
Undecided
Unassigned

Bug Description

Binary package hint: scratchbox2

The recent patch for solving the FTBFS needs to correctly handle the bug that was detected.

+- asprintf(&new_ld_preload, "%s:%s",
+- old_ld_preload, sbox_libsb2);
++ if (asprintf(&new_ld_preload, "%s:%s",
++ old_ld_preload, sbox_libsb2)) { }

This will just silence the warning -- new_ld_preload being NULL after the sprintf is an unhandled failure condition that needs to be tested, reported, and have the program abort accordingly. (See the other situations in "main" where this is done.)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.