Upgrade to 2.0.11 breaks admindb page

[Nhruby]

Hey, just upgraded to 2.0.11 from 2.0.5.

Upgraded by applying the patches (in correct order :) to
go from 2.0.5 to .2.0.22. All patches applied cleanly to
the 2.0.5 source with no errors.

reran the config.guess and re-ran make install,
everything went off without a hitch, after restarting
sendmail, httpd and cron after the upgrade procedure
and checking the test list the admindb webpage dies
with an error. All other pages work fine.

Here's the traceback:

May 21 16:32:19 2002 admin(9971):
@@@@@@@@@@@@@@@@@@@@@@@@
@@@@@@@@@@@@@@@@@@@@
admin(9971): [----- Mailman Version: 2.0.11 -----]
admin(9971): [----- Traceback ------]
admin(9971): Traceback (innermost last):
admin(9971): File "/home/mailman/scripts/driver", line
96, in run_main
admin(9971): main()
admin(9971): File "/home/mailman/Mailman/Cgi/
admindb.py", line 110, in main
admin(9971): if len(cgidata.keys()):
admin(9971): NameError: cgidata
admin(9971): [----- Python Information -----]
admin(9971): sys.version = 1.5.2 (#1, Aug 25 2000,
09:33:37) [GCC 2.96 20000731 (experimental)]
admin(9971): sys.executable = /usr/bin/python
admin(9971): sys.prefix = /usr
admin(9971): sys.exec_prefix= /usr
admin(9971): sys.path = /usr
admin(9971): sys.platform = linux-i386
admin(9971): [----- Environment Variables -----]
admin(9971): DOCUMENT_ROOT: /var/www/html
admin(9971): SERVER_ADDR: 128.192.51.21
admin(9971): QUERY_STRING:
admin(9971): SERVER_PORT: 80
admin(9971): PATH_TRANSLATED: /var/www/html/
testlist
admin(9971): REMOTE_ADDR: 128.192.51.220
admin(9971): HTTP_UA_OS: MacOS
admin(9971): HTTP_ACCEPT_LANGUAGE: en
admin(9971): GATEWAY_INTERFACE: CGI/1.1
admin(9971): SERVER_NAME:
nuttybar.drama.uga.edu
admin(9971): HTTP_CONNECTION: Keep-Alive
admin(9971): HTTP_USER_AGENT: Mozilla/4.0
(compatible; MSIE 5.14; Mac_PowerPC)
admin(9971): HTTP_ACCEPT: */*
admin(9971): REQUEST_URI: /mailman/admindb/
testlist
admin(9971): HTTP_UA_CPU: PPC
admin(9971): HTTP_EXTENSION: Security/Remote-
Passphrase
admin(9971): SCRIPT_FILENAME: /home/mailman/
cgi-bin/admindb
admin(9971): PATH_INFO: /testlist
admin(9971): HTTP_HOST: nuttybar.drama.uga.edu
admin(9971): REQUEST_METHOD: GET
admin(9971): SERVER_SIGNATURE: <ADDRESS>
Apache/1.3.14 Server at nuttybar.drama.uga.edu Port
80</ADDRESS>

admin(9971): SCRIPT_NAME: /mailman/admindb
admin(9971): SERVER_ADMIN: root@localhost
admin(9971): SERVER_SOFTWARE: Apache/1.3.14
(Unix) (Red-Hat/Linux)
admin(9971): PYTHONPATH: /home/mailman
admin(9971): HTTP_COOKIE: testlist:admin=
280200000069c3aeea3c73280000003034623331306
1396165613462396165353062636
633393934393139363738333237323539303864
admin(9971): SERVER_PROTOCOL: HTTP/1.1
admin(9971): REMOTE_PORT: 56839
admin(9971): HTTP_REFERER: http://
nuttybar.drama.uga.edu/mailman/admin/testlist

[http://sourceforge.net/tracker/index.php?func=detail&aid=558848&group_id=103&atid=100103]

[Barry Warsaw (barry)]

Please compare the Mailman/Cgi/admindb.py file against the
file at the top of the 2.0 maintainence branch:

http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/*checkout*/mailman/mailman/Mailman/Cgi/admindb.py?rev=1.36.2.7&only_with_tag=Release_2_0_11&content-type=text/plain

It sounds like there was a problem with the upgrade or the
install after upgrade (I know you didn't get any errors, but
still, I can't see why this exception would otherwise happen!)

[Nhruby (nhruby)]

Damn you're quick :)

Fixed by moving the following block of code starting at line
110 in mailman/Cgi/admindb.py over 5 spaces to the left...

--- CUT_N_PASTE
    cgidata = cgi.FieldStorage()
    try:
        Auth.authenticate(mlist, cgidata)
    except Auth.NotLoggedInError, e:
        Auth.loginpage(mlist, 'admindb', e.message)
        return
-- CUT_N_PASTE

perhaps there is something screwy with the patches in the
downlaod manager?

[Barry Warsaw (barry)]

I just looked at the 2.0.4 -> 2.0.5 patch and it looks okay
to me. That's the patch that should contain the fixed
indentation for those lines. Hmm...