allow use of default certificate store

Bug #264956 reported by Ludwig Nussel
2
Affects Status Importance Assigned to Milestone
pyOpenSSL
Fix Released
Medium
Jean-Paul Calderone

Bug Description

While trying to fix up one of our tools to support proper https I
found the following features missing from pyopenssl:

- it's not possible to pass a directory as certificate store. On
  openSUSE we have all trusted ca certificates in individual files
  in /etc/ssl/certs
- applications should not need to know about /etc/ssl/certs so the
  lib should just use SSL_CTX_set_default_verify_paths() to take the
  location built into the distro's openssl.

The attached patch implements both features without changing the
API.

Revision history for this message
Ludwig Nussel (l-n) wrote :
Revision history for this message
Jean-Paul Calderone (exarkun) wrote :

I've added support for a second optional argument to load_verify_locations and added a separate set_default_verify_paths method based on your patch. I think together these changes expose all the functionality you're interested in. I took this approach because I prefer to mimic the OpenSSL API as closely as possible. The code is still in the branch in the "Related branches" section, not trunk. Please let me know what you think, and hopefully I can merge this to trunk soon.

Changed in pyopenssl:
assignee: nobody → exarkun
status: New → In Progress
Revision history for this message
Ludwig Nussel (l-n) wrote :

fine with me, thanks! :)

Changed in pyopenssl:
milestone: none → 0.9
Revision history for this message
Jean-Paul Calderone (exarkun) wrote :

Alright, took a while, but I finally merged the branch.

Changed in pyopenssl:
importance: Undecided → Medium
status: In Progress → Fix Committed
Changed in pyopenssl:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.