In Page Info numbers for "visited today" are way too high

[Jan Rüegg]

Binary package hint: firefox

When going to "Tools -> Page Info" under the Tab Security, Firefox shows me (for example on the google web page):

Have I visited this web site before today? Yes, 9910 times

These numbers are always very high... Maybe this is how many times this web site was visited before *ever*, but sure enough not *today*.

Ubuntu: 8.04.1
Firefox: 3.0.1+build1+nobinonly-0ubuntu0.8.04.3

[Johnath (johnath)]

To be clear then:

 - The primary intent of the line is to communicate to the user whether this is a site they have visited "in the past," BUT
 - It's relatively straightforward for sites to build magic that gets their name added to history hundreds of times, either to deliberately undermine history-based UI, or just because they're buggy, SO
 - We want to use a test which removes that possibility by looking for history entries that existed before today, since those are substantially more work to inject, enough so that the "attack" (such as it is) is unlikely to occur.

Hence, the intended grouping (and maybe the low bar for a string recommendation here) is:

   "Have I visited this website (before today)?"

We don't want to drop the temporal reference ("Have I visited this website before?" or "Have I visited this website in the past?") because those will make our behaviour seem buggy on newly visited sites, where visits won't immediately show up.

Other suggestions are welcome.

[Ventnor-bugzilla (ventnor-bugzilla)]

"Have I visited this web site prior to today?"

[Jan Rüegg (rggjan)]

Binary package hint: firefox

When going to "Tools -> Page Info" under the Tab Security, Firefox shows me (for example on the google web page):

Have I visited this web site before today? Yes, 9910 times

These numbers are always very high... Maybe this is how many times this web site was visited before *ever*, but sure enough not *today*.

Ubuntu: 8.04.1
Firefox: 3.0.1+build1+nobinonly-0ubuntu0.8.04.3

[Andreas Moog (ampelbein)]

Thank you for your bugreport. Since this seems to be an issue with
version 3 of the firefox browser, I'm reassigning the package.

 affects ubuntu/firefox
 status invalid

 affects ubuntu/firefox-3.0
 status new

[Florian-queze (florian-queze)]

*** Bug 456198 has been marked as a duplicate of this bug. ***

[Andreas Moog (ampelbein)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. I reported this issue upstream, you can track the status and make comments here: https://bugzilla.mozilla.org/show_bug.cgi?id=456198

[Andreas Moog (ampelbein)]

Upstream comment:
It's the number BEFORE today, that is yesterday and all the days before. Not
today.

The current phrase might be grammatically correct, but it sounds a bit weird,
especially for people that don't speak English as their first language (we seem
to ignore the word 'before'). I think it should be rephrased as "Have I visited
this web site in the past, (not counting today)". Or just count all the visits
together, today included.

[Martin Mai (mrkanister-deactivatedaccount-deactivatedaccount)]

Reassigning to right upstream bug.

[L10n-mozilla (l10n-mozilla)]

Can we get this fixed in 3.7? Sounds like a nice bug to get started.

[A-topal (a-topal)]

Right, I'll take it :)

[A-topal (a-topal)]

Created attachment 419784
Michael's wording

I took Michaels wording, since it's clear and doesn't need parentheses.

BTW: my first patch to the product after 7 years in the project :)

[Johnath (johnath)]

Comment on attachment 419784
Michael's wording

>diff -r e9f33e85a979 browser/locales/en-US/chrome/browser/pageInfo.dtd
> <!ENTITY securityView.privacy.header "Privacy &amp; History">
>-<!ENTITY securityView.privacy.history "Have I visited this web site before today?">
>+<!ENTITY securityView.privacy.history2 "Have I visited this web site prior to today?">
> <!ENTITY securityView.privacy.cookies "Is this web site storing information (cookies) on my computer?">

Rev'ng the entity here is sort of a fine line, we're not changing the semantic meaning so much as clarifying it, but I guess it will likely cause the other english-based locales to update themselves. If you *do* rev the entity though, then you need to also update the source code anywhere that entity is used, so that it can resolve the entity once again.

Does that make sense?

MXR says you've only got one place to update anyhow: http://mxr.mozilla.org/mozilla-central/search?string=securityView.privacy.history

[L10n-mozilla (l10n-mozilla)]

Yea, I wouldn't rev the entity here.

[A-topal (a-topal)]

Created attachment 422269
Patch without rev change

Wow, I screwed up a one liner!

Hope it works better this time ;)

[A-topal (a-topal)]

Created attachment 422270
Patch without rev change AND correct indentation

Well, third time is a charm, or something :)

[Dao (dao)]

http://hg.mozilla.org/mozilla-central/rev/6eac956960a0

[Mozilla-bugs-alyoung (mozilla-bugs-alyoung)]

Verified Fixed.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a1pre) Gecko/20100120 Minefield/3.7a1pre (.NET CLR 3.5.30729) ID:20100120043108