getPathList doesn't work with newer rpm

[Anders F Björklund]

RPMTAG_OLDFILENAMES is deprecated, having been replaced with RPMTAG_DIRNAMES+RPMTAG_BASENAMES

[John (john-redhat-bugs)]

Description of problem:The 'Content' pane normally shows the result of 'rpm -ql' for the highlighted package. In fc10 it is empty.

Version-Release number of selected component (if applicable):1.1-56.fc10@x86_64

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info: This is the reply to my posting about this on the smart list

From: =?ISO-8859-1?Q?Anders_F_Bj=F6rklund?= <email address hidden>
Subject: Re: smart-gui 'Content' tab empty in Fedora 10
Date: Mon, 15 Dec 2008 17:33:37 +0100

> Hi: I've just installed Fedora 10 and have the x86_64 release version of smart and smart-gui in the KDE desktop. I haven't found a config option to show the useful 'rpm -ql' info that I see in the Centos 5.2 version: the panel is always empty. The other tabs work as usual. Have I missed something?

It's the newer RPM version, an old deprecated tag is now gone.

See https://bugs.launchpad.net/smart/+bug/263762 for patch...

--anders

[John (john-redhat-bugs)]

It didn't at first occur to me that I could simply edit in the 6-line patch to the .py file and expect it to work: but it works-for-me :-)

File is /usr/lib64/python2.5/site-packages/smart/backends/rpm/header.py

[Fedora (fedora-redhat-bugs)]

smart-1.1-58.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.

[Fedora (fedora-redhat-bugs)]

smart-1.1-58.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.

[Fedora (fedora-redhat-bugs)]

smart-1.1-58.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.

[John (john-redhat-bugs)]

I just installed 1.1-58.fc10@x86-64. The 'Content' tab is still empty.

After making Comment #1 above I found that although the pane was no longer empty after editing in the suggested patch to 1.1-56, its content was _not_ always identical with that given by 'rpm -ql'. I reported this to Anders, but not elsewhere.

[Fedora (fedora-redhat-bugs)]

smart-1.1-58.0.1.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/smart-1.1-58.0.1.fc10

[Axel (axel-redhat-bugs)]

(In reply to comment #6)
> I just installed 1.1-58.fc10@x86-64. The 'Content' tab is still empty.

This was a bad build, please try 1.1-58.0.1.fc10. Thanks!

[John (john-redhat-bugs)]

Downloaded and installed smart, smart-update, smart-gui 58.0.1 from the koji url.

The patch (if it's this one)

http://bazaar.launchpad.net/~afb/smart/sandbox/revision/936

still isn't here

/usr/lib64/python2.5/site-packages/smart/backends/rpm/header.py

and the pane is still empty :-(

Happy New Year!

[Axel (axel-redhat-bugs)]

OK, I thought this patch had made it into

https://code.launchpad.net/~smartpm/smart/bugfix

but I was wrong. So 1.1-58 will not fix it. I'll make another build, but I do want to get 1.1-58 out the door asap to fix all other issues.

[Axel Thimm (axel-thimm)]

Could this patch be merged into https://code.launchpad.net/~smartpm/smart/bugfix

Thanks!

[Anders F Björklund (afb)]

I wanted to refactor both this and #244771 into proper helper functions,
instead of duplicating the same code whenever it's needed. But sure.

[John (john-redhat-bugs)]

OK, it's not a major issue, although it would be nice to have it back - and perhaps the 'Changelog' tab that Anders mentioned, too. I didn't try that.

FYI, when I inserted the 'revision/936' patch as before, smart produced an error message and exited.

[Anders F Björklund (afb)]

Now merged from sandbox.

[Anders F Björklund (afb)]

i.e. http://bazaar.launchpad.net/~smartpm/smart/bugfix/revision/855

[Anders F Björklund (afb)]

Stupid thinko when I retrieved the lost patch made it not use RPMTAG_DIRINDEXES like it should. Fixed now, thanks to niemeyer for noticing.

[Fedora (fedora-redhat-bugs)]

smart-1.1-59.0.1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.

[Fedora (fedora-redhat-bugs)]

smart-1.1-59.0.1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.

[Gustavo Niemeyer (niemeyer)]

This was fixed in trunk with a similar implementation and full tests.

[Anders F Björklund (afb)]

Released, 2009-03-04