launchpad trac requires a change to trac installation!!

Bug #263241 reported by SoloTurn
6
Affects Status Importance Assigned to Milestone
Trac/Launchpad Plugin
Invalid
Undecided
Unassigned
launchpad-integration (Ubuntu)
Invalid
Low
Unassigned

Bug Description

launchpad - trac integration seems to be not a good citizen because:
 1. it should not require to change a trac installation if launchpad is a client
 2. if it is necessary, adjust the plugin, in this case xml-rpc to have a generalized solution and not a hack
 3. if this is not possible, add a plugin on http://trac-hacks.org

Revision history for this message
Sebastien Bacher (seb128) wrote :

thank you for your bug report, you opened a bug against the library used to add launchpad icons to ubuntu applications though, you probably want to open a bug on launchpad and not ubuntu

Changed in launchpad-integration:
importance: Undecided → Low
status: New → Invalid
Revision history for this message
Graham Binns (gmb) wrote :

I've targeted this to the plugin's Launchpad project.

I'm not quite clear on your points here:

 1. it should not require to change a trac installation if launchpad is a client

Trac doesn't offer the necessary APIs out of the box (at least at the moment), so the plugin is a necessity. Do you think there's another way to solve the problem that the plugin solves?

 2. if it is necessary, adjust the plugin, in this case xml-rpc to have a generalized solution and not a hack

I'm not clear on what you mean here. The plugin builds on top of the existing XML-RPC plugin for Trac. It does, however, require patches to be made to the Trac core for Trac 0.10 installations.

 3. if this is not possible, add a plugin on http://trac-hacks.org

I think this should be done anyway, but I'd like clarification on your points above before I proceed.

Changed in trac-launchpad:
assignee: nobody → gmb
status: New → Incomplete
Revision history for this message
Tim Hatch (timhatch) wrote :

Hi, I'm the author of the plugin. I'll be glad to discuss ways to make it better, but like Graham I need to know more about what you mean and specifically why it upsets you.

> launchpad - trac integration seems to be not a good citizen because...

A good citizen of... ubuntu? If that's the case, is it the lack of a .deb?

> > 1. it should not require to change a trac installation if launchpad is a client
> Trac doesn't offer the necessary APIs out of the box (at least at the moment), so the plugin is a necessity. Do you think there's another way to solve the problem that the plugin solves?

Trac does not support the launchpad bugtracker api out of the box (nor should it, that's the whole reason that the plugin system exists). It's not that the xml-rpc plugin alone _can't_ do what we need (with lots of changes on the lp side), it's that it doesn't do so efficiently (it would use a lot of bandwidth even when nothing has changed) and authentication would be a bear to set up in some other way that would likely be less secure.

> > 2. if it is necessary, adjust the plugin, in this case xml-rpc to have a generalized solution and not a hack
> I'm not clear on what you mean here.

I think he means the patch to trac core required for the lp bug ticket field to linkify on 0.10, which is optional.

> > 3. if this is not possible, add a plugin on http://trac-hacks.org
> I think this should be done anyway, but I'd like clarification on your points above before I proceed.

Do you mean for it to be listed in the wiki on t-h? It's a wiki, editable by anyone.

Revision history for this message
SoloTurn (soloturn) wrote :

1: is my misunderstanding, sorry. i ment the patch, but this is not necessary for recent versions of trac.
2: it would be great if you'd improve the existing xml-rpc plugin, it is anyway orphaned currently.
    imo it is bad design if a plugin on the trac side is specifically designed for launchpad (or, a client
    software in general). because there is other software as well suffering from the deficiencies
    - like e.g. mylyn, or trac itself by overloading the trac server. this is also valid for backlinks, it
    should ideally not be launchpad specific.
3.: uploading it ti t-h would be in any case great.

SoloTurn (soloturn)
Changed in trac-launchpad:
status: Incomplete → New
Graham Binns (gmb)
Changed in trac-launchpad:
assignee: Graham Binns (gmb) → nobody
SoloTurn (soloturn)
Changed in trac-launchpad:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.