probe-storage does not recover from error setting storage.serial

[John C Barstow]

Here's the relevant section of a hald log (run 'sudo hald --daemon=no --verbose=yes' after stopping dbus)

25160: 14:40:58.694: probe-storage.c:167: serial = 'ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ', firmware = '1.19'
14:40:58.695 [I] hald_dbus.c:2693: local_server_message_handler: destination=(null) obj_path=/org/freedesktop/DBus/Local interface=org.freedesktop.DBus.Local method=Disconnected
14:40:58.695 [I] hald_dbus.c:2709: Client to local_server was disconnected
14:40:58.695 [I] hald_dbus.c:2719: unregistered
25160: 14:40:58.695: probe-storage.c:172: Error setting storage.serial
25160: 14:40:58.695: probe-storage.c:180: Error setting storage.firmware_version
25160: 14:40:58.696: probe-storage.c:212: Doing open ("/dev/hda", O_RDONLY | O_NONBLOCK)
25160: 14:40:58.701: probe-storage.c:218: Returned from open(2)

####repeated many times####
25160: arguments to dbus_connection_send_with_reply_and_block() were incorrect, assertion "(error) == NULL || !dbus_error_is_set ((error))" failed in file dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.

It looks like the device in question has issues with supplying a serial number; the error is flagged but never recovered from. As a result dbus never sets any of the cdrom properties.

[John C Barstow (jbowtie)]

Distro = ubuntu, breezy badger

'uname -r' = 2.6.12-9-k7

hal - Version: 0.5.3-0ubuntu12
dbus - Version: 0.36.2-0ubuntu6

[John C Barstow (jbowtie)]

Here's the relevant section of a hald log (run 'sudo hald --daemon=no
--verbose=yes' after stopping dbus)

25160: 14:40:58.694: probe-storage.c:167: serial = 'ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ', firmware =
'1.19'
14:40:58.695 [I] hald_dbus.c:2693: local_server_message_handler:
destination=(null) obj_path=/org/freedesktop/DBus/Local
interface=org.freedesktop.DBus.Local method=Disconnected
14:40:58.695 [I] hald_dbus.c:2709: Client to local_server was disconnected
14:40:58.695 [I] hald_dbus.c:2719: unregistered
25160: 14:40:58.695: probe-storage.c:172: Error setting storage.serial 25160:
14:40:58.695: probe-storage.c:180: Error setting storage.firmware_version
25160: 14:40:58.696: probe-storage.c:212: Doing open ("/dev/hda", O_RDONLY |
O_NONBLOCK)
25160: 14:40:58.701: probe-storage.c:218: Returned from open(2)

####repeated many times####
25160: arguments to dbus_connection_send_with_reply_and_block() were incorrect,
assertion "(error) == NULL || !dbus_error_is_set ((error))" failed in file
dbus-connection.c line 2755.
This is normally a bug in some application using the D-BUS library.

It looks like the device in question has issues with supplying a serial number;
the error is flagged but never recovered from. As a result dbus never sets any
of the cdrom properties.

Distro = ubuntu, breezy badger

'uname -r' = 2.6.12-9-k7

hal - Version: 0.5.3-0ubuntu12
dbus - Version: 0.36.2-0ubuntu6

[John C Barstow (jbowtie)]

Had a chat on IRC last night with sjoerd (the debian package maintainer); he
believes that probe-storage should be sanity checking the serial number
(presumably version should also be sanity checked) and not setting it if invalid.

[John C Barstow (jbowtie)]

Entered in upstream bugzilla as bug #5008

https://bugs.freedesktop.org/show_bug.cgi?id=5008

[Danny Kukawka (danny-kukawka)]

2005-11-10 Danny Kukawka <email address hidden>

 * hald/linux2/probing/Makefile.am: updated for glib

 * hald/linux2/probing/probe-storage.c: (strdup_valid_utf8), (main):
   Fix to prevent sending invalid UTF8 strings from storage serials to D-BUS
   which prevent adding the whole storage divice to the device store. The
   invalid, non UTF8, characters replaced now with '?' and the serial only
   added if there is at least one valid character left in the string.

[John C Barstow (jbowtie)]

This was fixed long time ago, but for some reason the status was never updated.