Queue rejection via the UI results in broken emails

[Celso Providelo]

I sponsored the following upload and got the Reply "Rejected: None"

Rejected:
None

********* *BEGIN ENCRYPTED or SIGNED PART* *********

Format: 1.8
Date: Wed, 18 Jun 2008 15:44:48 +0400
Source: libjna-java
Binary: libjna-java libjna-java-doc
Architecture: source
Version: 3.0.4-0ubuntu1
Distribution: intrepid
Urgency: low
Maintainer: Ubuntu MOTU Developers <email address hidden>
Changed-By: Yulia Novozhilova <email address hidden>
Description: .....

[Celso Providelo (cprov)]

Julian, can you please investigate this issue ?

[Julian Edwards (julian-edwards)]

Daniel, do you still have the email that you received? Can you attach it here please? (So I can see headers, etc)

[Daniel Holbach (dholbach)]

No, sorry - I deleted it - I just have the one I bounced to ubuntu-motu - the headers might be useless. :-(((((

[Julian Edwards (julian-edwards)]

Ah never mind, I found the rather obvious bug in the code :-)

[Julian Edwards (julian-edwards)]

Actually Daniel, what would you expect to see instead of "None" ? There is normally no message for rejections from the queue although we could add one quite easily. "None" is Python's way of telling you it really loves you when you supply it an empty list to a string replacement :-)

[Daniel Holbach (dholbach)]

Either no message at all, or (much more helpful) a way for the archive admin to say: "I rejected the package because of this broken license, this missing explanation" or generall say: "please fix a, b, c and try again"

"Rejected: None" itself is just a bit confusing. :-)

[Julian Edwards (julian-edwards)]

Right, thanks Daniel. Muharem is fixing the email format anyway so this is an easy add-on.

Cheers!

[Muharem Hrnjadovic (al-maisan)]

Related to bug #271413

[Muharem Hrnjadovic (al-maisan)]

RF 7099