Launchpad itself

+addbranch and +addsubscriber don't use standard Cancel mechanism

Bug #261763 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Gavin Panella
Launchpad itself 2.1.9

Bug Description

As of mainline r6907, the +addbranch (e.g. <https://bugs.staging.launchpad.net/rosetta/+bug/3/+addbranch>) and +addsubscriber (e.g. <https://bugs.staging.launchpad.net/rosetta/+bug/3/+addsubscriber>) pages have a "Cancel" button.

As described in <https://launchpad.canonical.com/UserInterfaceChecklist> (and in my comment in bug 243259), they should instead use the standard cancel_url Cancel mechanism, which (currently) produces a Cancel link rather than a button. That way if we change the way we present cancel actions later on, these pages will change automatically.

This bug should have been caught during code review.

It may save time to fix bug 144636 at the same time as this bug.

Tags: lp-bugs
Matthew Paul Thomas (mpt)
Changed in malone:
assignee: nobody → allenap
Revision history for this message
Gavin Panella (allenap) wrote :

Ah ha, I misunderstood your comment in bug 243259. I still have several more pages to modify as part of that bug, so I'll change the cancel buttons at the same time. And, you're right, it will be easy to fix bug 144636 at the same time.

Gavin Panella (allenap)
Changed in malone:
milestone: none → 2.1.9
status: New → In Progress
Revision history for this message
Gavin Panella (allenap) wrote :

In RF 6945.

Changed in malone:
status: In Progress → Fix Committed
Björn Tillenius (bjornt)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.