new player gets assigned to team red when switching from SP to multiplayer mode

[Yann Kaiser]

Steps to reproduce:
1/ Start a dedicated server
2/ Enter it
3/ Wait a round or so
4/ Enter with a new client

Workarounds:
* SP_TEAMS_MAX 2
* Use the default fortress map (same as the previous w/a, technically)

[Yann Kaiser (epsy)]

Marking this as incomplete, i want to see it with my own eyes

[Manuel Moos (z-man)]

Yeah, definitely, more info to reproduce it would be required. Who reported it initially?

[Yann Kaiser (epsy)]

I think it was either kyle or eddie

Manuel Moos wrote:
> Yeah, definitely, more info to reproduce it would be required. Who
> reported it initially?
>
> ** Changed in: armagetronad
> Assignee: (unassigned) => Manuel Moos (z-man)
>
>

[Yann Kaiser (epsy)]

ah, whoops, it seems it was eddie actually, as confirmed here <https://bugs.launchpad.net/armagetronad/+bug/261469> at 15:01

[Yann Kaiser (epsy)]

errr, stupid me, that's the wrong paste

http://wrtlprnft.ath.cx/armalogs/log-2008-08-26.txt

[Manuel Moos (z-man)]

Ah. The bug description was misleading, then. The problem is this:
- Player 1 enters, gets team blue
- AI enters, gets team gold
- time passes
- Player 2 enters, all teams are used, he gets team red if he configured his client to prefer to create new teams
- Arma switches to multiplayer mode
- AI gets removed
- Team blue and red are kept

TEAM_ELIMINATION_MODE 1 also solves the issue, according to the chat, and that makes sense.

It's not really a bug, probably (will think about it for a bit). It may be undesired behavior, but since config items exist to make it go away, and all individual systems behave like they should; it's just the combination that turns out to be not what the admin wants.

A possible solution may be to reset team names on sp/mp transitions, then do team eliminations, then give the teams new names. But then, the teams may shuffle around on the transition (specifically, no matter where you were, you'll be playing for team blue after a mp->sp transition).

[Manuel Moos (z-man)]

Easiest solution not breaking anything else: the team color selection code now assigns new colors if the color index is bigger than the maximal number of teams.