loom needs to hook into 'bzr nick' to make that rename the thread -or- refuse to change.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Loom |
Fix Released
|
Medium
|
Robert Collins |
Bug Description
0 seb@water /home/seb/
module-interface
=>upstream
0 seb@water /home/seb/
All changes applied successfully.
Moved to thread 'module-interface'.
0 seb@water /home/seb/
module-interface
0 seb@water /home/seb/
bzr: ERROR: exceptions.
Traceback (most recent call last):
File "/usr/lib/
return run_bzr(argv)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
branch.nick = nickname
File "/usr/lib/
self.
File "/usr/lib/
self.
File "/usr/lib/
self.
File "/usr/lib/
if dict(state.
KeyError: u'minor-fixes'
bzr 1.5 on python 2.5.2 (linux2)
arguments: ['/usr/bin/bzr', 'nick', 'minor-fixes']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
bzrtools /usr/lib/
dbus /usr/lib/
gtk /usr/lib/
launchpad /usr/lib/
loom /usr/lib/
qbzr /usr/lib/
rebase /usr/lib/
svn /usr/lib/
*** Bazaar has encountered an internal error.
Please report a bug at https:/
including this traceback, and a description of what you
were doing when the error occurred.
Related branches
- Paul Hummer (community): Approve
-
Diff: 2313 lines (+1033/-321)18 files modified.testr.conf (+4/-0)
HOWTO (+19/-1)
NEWS (+102/-2)
README (+5/-3)
TODO (+1/-2)
__init__.py (+26/-7)
branch.py (+226/-126)
commands.py (+107/-40)
formats.py (+74/-0)
revspec.py (+67/-32)
setup.py (+3/-5)
tests/__init__.py (+4/-1)
tests/blackbox.py (+147/-19)
tests/test_branch.py (+84/-35)
tests/test_revspec.py (+49/-5)
tests/test_tree.py (+29/-13)
tree.py (+58/-30)
version.py (+28/-0)
summary: |
- "internal error" when changing nick in a loom thread + loom needs to hook into 'bzr nick' to make that rename the thread -or- + refuse to change. |
Changed in bzr-loom: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in bzr-loom: | |
status: | Confirmed → Fix Released |
assignee: | nobody → Robert Collins (lifeless) |
milestone: | none → 2.2 |
After the above command resulted in an internal error, the nick was changed, and the branch was left locked with no thread selected:
4 seb@water /home/seb/ emc2/module- interface> bzr nick emc2/module- interface> bzr show-loom emc2/module- interface> bzr up-thread /home/seb/ emc2/module- interface/ .bzr/repository /lock
minor-fixes
0 seb@water /home/seb/
module-interface
upstream
0 seb@water /home/seb/
Unable to obtain lock file://
held by <email address hidden> on host water [process #17677]
locked 5 minutes, 9 seconds ago
Will continue to try until 14:50:13
^Cbzr: interrupted
I broke the lock, but the branch seems sort of horked now:
3 seb@water /home/seb/ emc2/module- interface> bzr break-lock /home/seb/ emc2/module- interface/ .bzr/branch/ lock /home/seb/ emc2/module- interface/ .bzr/repository /lock emc2/module- interface> bzr nick emc2/module- interface> bzr show-loom emc2/module- interface> bzr down-thread KeyError: u'minor-fixes'
Break lock file://
held by <email address hidden> on host water [process #17677]
locked 5 minutes, 19 seconds ago? [y/n]: y
Break lock file://
held by <email address hidden> on host water [process #17677]
locked 5 minutes, 21 seconds ago? [y/n]: y
0 seb@water /home/seb/
minor-fixes
0 seb@water /home/seb/
module-interface
upstream
0 seb@water /home/seb/
bzr: ERROR: exceptions.
Traceback (most recent call last): python2. 5/site- packages/ bzrlib/ commands. py", line 846, in run_bzr_ catch_errors python2. 5/site- packages/ bzrlib/ commands. py", line 797, in run_bzr python2. 5/site- packages/ bzrlib/ commands. py", line 499, in run_argv_aliases **all_cmd_ args) python2. 5/site- packages/ bzrlib/ plugins/ loom/commands. py", line 274, in run thread( thread) python2. 5/site- packages/ bzrlib/ decorators. py", line 167, in write_locked python2. 5/site- packages/ bzrlib/ plugins/ loom/tree. py", line 231, in unlock tree.unlock( ) python2. 5/site- packages/ bzrlib/ workingtree_ 4.py", line 1146, in unlock branch. unlock( ) python2. 5/site- packages/ bzrlib/ plugins/ loom/branch. py", line 687, in unlock get_threads_ dict()) [self.nick] [0] != lastrev:
File "/usr/lib/
return run_bzr(argv)
File "/usr/lib/
ret = run(*run_argv)
File "/usr/lib/
return self.run(
File "/usr/lib/
return tree.down_
File "/usr/lib/
self.unlock()
File "/usr/lib/
self.
File "/usr/lib/
self.
File "/usr/lib/
if dict(state.
KeyError: u'minor-fixes'
bzr 1.5 on python 2.5.2 (linux2) python2. 5/site- packages/ bzrlib/ plugins/ bzrtools [1.5.0] python2. 5/site- packages/ bzrlib/ plugins/ dbus [unknown] python2. 5/site- packages/ bzrlib/ plugins/ gtk [0.94.0] python2. 5/site- packages/ bzrlib/ plugins/ launchpad [unknown] python2. 5/site- packages/ bzrlib/ plugins/ loom [1.4.0dev0] python2. 5/site- packages/ bzrlib/ plugins/ qbzr [0.9.2] python2. 5/site- packages/ bzrlib/ plugins/ rebase [0.3.0] python2. 5/site- packages/ bzrlib/ plugins/ svn [0.4.10]
arguments: ['/usr/bin/bzr', 'down-thread']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
bzrtools /usr/lib/
dbus /usr/lib/
gtk /usr/lib/
launchpad /usr/lib/
loom /usr/lib/
qbzr /usr/lib/
rebase /usr/lib/
svn /usr/lib/
*** Bazaar has encountered an ...