Pixbuf memory leak

[Alessandro Decina]

The widgets in our UI contain a lot of reference cycles. It's especially bad as most of the widgets contain pigment images. Images hold pixbuf memory until they are dellocated. In other words, between collection cycles, we keep in memory all the pixbuf memory that we allocate.

I have debugged and fixed all the cycles. The fixes are hackish in some places as I don't know UI code at all. The code is at lp:~alessandro.decina/pigment/widget_leaks and lp:~elisa-developers/elisa/widget_leaks.

[Guillaume Emont (guijemont)]

There's a big functional regression with these patches applied. When switching view mode to switch to coverflow or grid mode, keyboard navigation breaks, and you get a lot of tracebacks (one is attached).

[Guillaume Emont (guijemont)]

Also, according to my measurements, latest upicek + latest pigment with these patches: still leaks.

[Alessandro Decina (alessandro.decina)]

No one said it fixes all the leaks. It's only about pixbufs.
A way to check that is to use the pigment branch above and start elisa with PGM_DEBUG=pgm_image:5.
Then enter and leave a level, the number (and ids) of the the pixbuf allocated and deallocated should match.

[Loïc Molinari (loic.molinari)]

The fix to free the GdkPixbuf after upload to video memory when an image is set from a file is committed in Pigment revision 1278 [1]. As it's been said by Guillaume it improves a lot the memory comsumption of Elisa, but it still remains a bunch of annoying memory leaks.

[1] https://code.fluendo.com/pigment/trac/changeset/1278

[Loïc Molinari (loic.molinari)]

The commit 1278 in Pigment for this bug changed the API, the signal PgmImage::pixbuf-loaded is now called PgmImage::file-loaded. You have to apply this attached patch.

[yyoyo (lionel.martin)]

I close this bug.

Others leaks are still in Elisa, we will open specific bugs for them.