Landscape Client

sysinfo runs processes in a way that could possibly freeze forever

Bug #260231 reported by Christopher Armstrong
2
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Released
Medium
Christopher Armstrong
Landscape Server
Fix Released
Medium
Christopher Armstrong
Landscape Server thames-pre-7

Bug Description

since sysinfo runs plugins before the reactor starts, the plugins have a chance to start plugins before the reactor starts, which is bad because the SIGCHLD handler isn't installed yet.

The entire sysinfo run should be delayed until the reactor starts.

Revision history for this message
Christopher Armstrong (radix) wrote :

Linked branch has fix and tests. Please review.

Changed in landscape-client:
assignee: nobody → radix
importance: Undecided → Medium
status: New → In Progress
Changed in landscape:
assignee: nobody → radix
importance: Undecided → Medium
milestone: none → thames-pre-7
status: New → In Progress
Revision history for this message
Thomas Herve (therve) wrote :

[1] Flakes
landscape/sysinfo/tests/test_deployment.py:9: 'ANY' imported but unused

That's terrible, but fix the problem :). +1.

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Indeed! :-) Nice to have tests for this, though. +1!

Revision history for this message
Christopher Armstrong (radix) wrote :

Thanks guys, merged.

Changed in landscape:
status: In Progress → Fix Committed
Changed in landscape-client:
status: In Progress → Fix Committed
Revision history for this message
Andreas Hasenack (ahasenack) wrote :

This was released into production.

Changed in landscape-client:
status: Fix Committed → Fix Released
Changed in landscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.