Wrong mode of .bzr files when pushed via FTP

[René 'Necoro' Neumann]

After pushing a local branch to my webspace using FTP, I cannot branch from there using HTTP. This is because all changed files get the mode 0600 - thus disallowing the HTTP server to access these files.

> bzr pull
Using saved location: http://something
bzr: ERROR: Transport error: Server refuses to fulfill the request (403 Forbidden) for http://something/.bzr/repository/pack-names

Fixing the modes makes it work :)

[Vincent Ladeuil (vila)]

On IRC jam provides the following patch which fixed the problem.

[John A Meinel (jameinel)]

The basic issue is that FTPTransport.stat() returns a value rather than raising TransportNotPossible. So we trust the returned mode. However, it always returns 0000 as the file/directory permissions.

Our code then translates this into 0700 (because we do (mode & 07777) | 0700, so that directories and files are always writable by the current user.)

My workaround detects when the transport doesn't return proper bits for the directory (assuming that mode = 0000 is *never* valid). And then just reverts to not trying to chmod new files. Which seems like a reasonable workaround.

It would be nicer if FTPTransport.stat() returned the mode bits for the directory, but it might be difficult for the ftp protocol.

[pdf23ds (pdf23ds)]

I got exactly the same problem, except that the initial URL was /branch-format. Running version 1.8rc1