sysinfo should display information about disk usage

[Christopher Armstrong]

A header should be printed with the 'primary' disk usage, and a Note should be added for any filesystem using over a certain percentage of its capacity.

[Christopher Armstrong (radix)]

Ready for review in the attached branch

[Jamu Kakar (jkakar)]

[1]

+ - device: The device file which is mounted.
+ - mount-point
+ - filesystem: The filesystem type.

A description for 'mount-point' would be nice. Something like:

mount-point: The path to the root of the filesystem.

[2]

+ self._sysinfo.add_header("Usage of " + main_filesystem["mount-point"],

The header would be a touch more informative with actual values
included in the output:

  Usage of /home: 44.7% (34GB/76GB)

This is cool! I think adding configuration to this plugin should be
done before the feature is shipped with Intrepid, but that can be
done in a subsequent branch.

+1!

[Kevin McDermott (bigkevmcd)]

+def get_filesystem_for_path(path, mounts_file, statvfs_):

This doesn't seem to handle symlinked paths too well?

Sadly, os.statvfs on Python doesn't return the fs_fid field from Linux :-(

Depends how serious we think this is...

And #2 of Jamu's review is definitely pretty useful...

[Thomas Herve (therve)]

[1] Flakes
landscape/sysinfo/disk.py:4: 'statvfs' imported but unused
landscape/sysinfo/disk.py:8: 'MountInfo' imported but unused
landscape/lib/disk.py:3: 'os' imported but unused

[2] Some trailing whitespaces (disk.py, test_disk.py, test_mountinfo.py)

[3] There is a little problem with the note about capacity: it's on if I have a CD or DVD in my machine (reporting it as 100%). Maybe filtering iso9660 and udf is enough

[4]
+ kwargs["statvfs"] = lambda path: (0,0,0,0,0,0,0,0,0,0)
(0,) * 10 ?

That's cool, +1, [3] is the only point worrying me a bit.

[Christopher Armstrong (radix)]

Ok, all points fixed.

therve: indeed, I've gone with checking the filesystem type to ignore optical drives.

[Christopher Armstrong (radix)]

I'd really like another look at this before I merge it, since there were some significantish changes.

[Thomas Herve (therve)]

Still good for me!

[Andreas Hasenack (ahasenack)]

This was released into production.