Support --geometry argument

Bug #259511 reported by Marc Ordinas i Llopis
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Wishlist
Thomas Hurst

Bug Description

gnome-terminal supports the standard --geometry argument for passing the desired window dimensions when starting. I wish this was supported in terminator.

Revision history for this message
Chris Jones (cmsj) wrote :

I agree we should probably support this, marking as a wishlist, targetted for 1.0

Changed in terminator:
importance: Undecided → Wishlist
milestone: none → 1.0-beta
status: New → Confirmed
Revision history for this message
Thomas Hurst (tom.hurst) wrote :

Added to trunk.

Changed in terminator:
assignee: nobody → tom.hurst
status: Confirmed → Fix Committed
Chris Jones (cmsj)
Changed in terminator:
status: Fix Committed → Fix Released
Revision history for this message
Marc Ordinas i Llopis (marcoil) wrote :

Great, thanks for the fast fix!

Revision history for this message
Marc Ordinas i Llopis (marcoil) wrote :

In the last released package, it seems that terminator interprets the --geometry argument as a pixel value, making it behave very differently to gnome-terminal, which interprets it as a characters value.

To test, just do terminator --geometry=80x40, a very small window appears.

Revision history for this message
Markus Birth (mbirth) wrote :

I think terminator should behave the same way as gnome-terminal does and interprete the geometry values as rows*cols instead of pixels.

Changed in terminator:
status: Fix Released → Incomplete
Revision history for this message
Chris Jones (cmsj) wrote :

While that might make sense at the moment, I'm a little wary about doing that because in the future we will be adding the ability to save layouts, and so you'll be asking it to show X rows and Y columns across multiple terminals which may have different font sizes.

Revision history for this message
Thomas Hurst (tom.hurst) wrote :

I think if you want a way to specify how big a terminal is in rows and columns of text, you're better off having an option specifically for that, rather than co-opting --geometry and making it impossible to size new windows accurately.

As Chris points out, even if I did like this idea, what happens when layout saving and profiles land and someone has 8pt fonts for a couple of log tails and 12pt for other terms? How big is a character then?

Revision history for this message
Chris Jones (cmsj) wrote :

On the basis that the saved-layout future will make columns/lines interpretation of --geometry very hard, I suggest we not do it, so I'm setting the bug back to Fix Released.

Changed in terminator:
status: Incomplete → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.