qlog fails with repeated "list index out of range"

[Russ Brown]

qlog displays properly at first, then the commit messages dissappear completely, there is no graph, and the following is dumped to the command line a number of times:

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/plugins/qbzr/lib/log.py", line 167, in drawDisplay
    color = self.node[1].toInt()[0]
IndexError: list index out of range

It is also dumped while ever the mouse pointer is moving over the qlog window.

This should be reproducable by issuing the following command:

bzr qlog lp:~pickscrape/loggerhead/directory_breadcrumbs

... though I am actually getting it when running qlog against any branch.

I am running bzr 1.6rc1, and qbzr 0.9.2. Also reproduced with the current trunk version of qbzr.

[Lukáš Lalinský (luks)]

Works for me, what version of PyQt and Qt are you using?

[Alexander Belchenko (bialix)]

Works for me too with bzr 1.5.

[Russ Brown (pickscrape)]

I just tried it against bzr 1.5 and got the same behaviour. It's really weird because I only tried qbzr a couple of days ago and it was working just fine then!

libqt4-core version is 4.4.0-1ubuntu5~hardy1

python-qt4 version is 4.4.3-0ubuntu1~hardy1~ppa1

I'll dig deeper at my end and see if I can figure anything else out.

[Mark Hammond (mhammond)]

FWIW, I see this on Windows using Qt 4.4.1.0, but not using 4.4.0.0. Digging a little deeper, things worked fine with Qt*.dll from 4.4.1.0, and even PyQt4.QtGui.pyd - but started happening as soon a I used PyQt4.QtCore.pyd from 4.4.1.0.

To be sure I made one final test: 4.4.1.0 fails, then replacing *only* PyQt4.QtCore.pyd with the version from 4.4.0.0 is enough to make it work.

[Mark Hammond (mhammond)]

I was testing this in a binary build - so I mean PyQt4/QtCore.pyd - that extra '.' is an artifact of py2exe...

[Lukáš Lalinský (luks)]

The problem seems to be broken QVariant in that version of PyQt:

In [13]: from PyQt4.QtCore import QVariant

In [14]: QVariant([QVariant(1), QVariant(3)]).toList()
Out[14]: []

[Lukáš Lalinský (luks)]

It was actually API breakage in PyQt, though I don't understand what they did it in a minor release.

[Russ Brown (pickscrape)]

Confirmed that this fix works for me. :)