Dialogs remain open when a document is closed, and crash when used

[Leif Ryge]

Steps to reproduce:
1. Create two new documents
2. In one of them, open the layers dialog in a detached window
3. Close the document from which the layers dialog was opened from

Expected result:
Dialogs should close when their document is closed.

Actual result:
Closed documents' dialogs remain open. When the user attempts to use the dialog, eg to switch layers or add a new layer, Inkscape crashes.

Notes:
This bug must have been introduced in Inkscape 0.46, since dialogs in 0.45 were not window-specific (and I cannot crash 0.45 this way). This bug has been observed in OS X and Linux. This backtrace is from the Inkscape 0.46 package in Ubuntu Hardy on PowerPC:

[Switching to Thread 0x30047190 (LWP 20996)]
0x1003fda4 in ?? ()
(gdb) bt
#0 0x1003fda4 in ?? ()
#1 0x1015ac24 in ?? ()
#2 0x10294fcc in ?? ()
#3 0x10296300 in ?? ()
#4 0x10297590 in ?? ()
#5 0x102975f4 in ?? ()
#6 0x0fa56478 in Glib::SignalProxyNormal::slot0_void_callback () from /usr/lib/libglibmm-2.4.so.1
#7 0x0f0d26cc in g_cclosure_marshal_VOID__VOID () from /usr/lib/libgobject-2.0.so.0
#8 0x0f0c124c in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#9 0x0f0dab24 in ?? () from /usr/lib/libgobject-2.0.so.0
#10 0x0f0dc688 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#11 0x0f0dcaa8 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#12 0x0f425728 in gtk_button_clicked () from /usr/lib/libgtk-x11-2.0.so.0
#13 0x0f4275c4 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#14 0x0fdb2c1c in Gtk::Button_Class::released_callback () from /usr/lib/libgtkmm-2.4.so.1
#15 0x0f0d26cc in g_cclosure_marshal_VOID__VOID () from /usr/lib/libgobject-2.0.so.0
#16 0x0f0bf488 in ?? () from /usr/lib/libgobject-2.0.so.0
#17 0x0f0c124c in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#18 0x0f0da5c0 in ?? () from /usr/lib/libgobject-2.0.so.0
#19 0x0f0dc688 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#20 0x0f0dcaa8 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#21 0x0f4257d8 in gtk_button_released () from /usr/lib/libgtk-x11-2.0.so.0
#22 0x0f425814 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#23 0x0feb1a88 in Gtk::Widget_Class::button_release_event_callback () from /usr/lib/libgtkmm-2.4.so.1
#24 0x0f527914 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#25 0x0f0bf488 in ?? () from /usr/lib/libgobject-2.0.so.0
#26 0x0f0c124c in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#27 0x0f0da968 in ?? () from /usr/lib/libgobject-2.0.so.0
#28 0x0f0dc388 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#29 0x0f0dcaa8 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
#30 0x0f67e944 in ?? () from /usr/lib/libgtk-x11-2.0.so.0
#31 0x0f51eda0 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
#32 0x0f520764 in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#33 0x1003c7b8 in ?? ()
#34 0x0f313c08 in ?? () from /usr/lib/libgdk-x11-2.0.so.0
#35 0x0ef6ebd8 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#36 0x0ef72e4c in ?? () from /usr/lib/libglib-2.0.so.0
#37 0x0ef732d4 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#38 0x0f520cb4 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#39 0x0fe0c794 in Gtk::Main::run_impl () from /usr/lib/libgtkmm-2.4.so.1
#40 0x0fe0c3f8 in Gtk::Main::run () from /usr/lib/libgtkmm-2.4.so.1
#41 0x1003d694 in ?? ()
#42 0x101c00c8 in ?? ()
#43 0x1003d100 in ?? ()
#44 0x0de73b10 in ?? () from /lib/libc.so.6
#45 0x0de73cd0 in __libc_start_main () from /lib/libc.so.6
#46 0x00000000 in ?? ()

[Alvin Penner (apenner)]

running Windows XP, Inkscape 0.46 built April 1, the Layers dialog box closes automatically when the parent document closes

[Alvin Penner (apenner)]

- cannot reproduce this in Windows XP development build.
- can you confirm that this is still happening on a recent development build?

[jazzynico (jazzynico)]

Confirmed on Ubuntu 9.04, Inkscape 0.46 and rev. 21449.

Layer crash may be link to Bug #378097.
Floating dialog not closing with the document also affects transform (Bug #216693), Fill and stroke, Document properties and probably others.

[Beluga (buovjaga)]

I confirm the dialog stays open, but no crash happens.

Arch Linux 64-bit
Inkscape 0.91 r13725

[jazzynico (jazzynico)]

No crash on Windows XP, Inkscape 0.91.

[Qantas94Heavy (qantas94heavy)]

Dialog stays open but does not appear to be window-specific. The dialog will create a new layer in the remaining document when "add layer" button is clicked after closing.

Assuming this is fixed as it has not been reproduced in a long time and the behaviour now seems to be as expected.