#104: error while committing changes

[Benjamin Drung]

The five-a-day-applet shows an "error 104" message after dragging an item on it. This message disappears very fast and is meaningless. Looking into the source code shows that error appears in /fiveaday/bzr.py and have something to do with bzr.

[Benjamin Drung (bdrung)]

Here is a screen shot of the meaningless error description.

[Benjamin Drung (bdrung)]

$ 5-a-day --add 257757
No revisions to pull.
Committing to: /home/skipper/.5-a-day-bdrung/
modified data
Committed revision 132.
No revisions to pull.
Unable to obtain lock lp-147262220:///~bdrung/5-a-day-data/main/.bzr/branch/lock
held by <email address hidden> on host vostok [process #19492]
locked 4 hours, 50 minutes ago
Will continue to try until 23:22:21, unless you press Ctrl-C
If you're sure that it's not being modified, use bzr break-lock lp-147262220:///~bdrung/5-a-day-data/main/.bzr/branch/lock
bzr: ERROR: Could not acquire lock "(remote lock)"
Aufruf von bzr schlug fehl mit Fehlercode 768

[Daniel Holbach (dholbach)]

It'd be nice if the applet was a bit more explicit about the error.

I'm not sure how we could programmatically run
  bzr break-lock lp-147262220:///~bdrung/5-a-day-data/main/.bzr/branch/lock
for the user.... hm :-/

[Benjamin Drung (bdrung)]

It will be more complicated, when the user should run a command that does not work:

$ bzr break-lock lp-147262220:///~bdrung/5-a-day-data/main/.bzr/branch/lock
bzr: ERROR: Unsupported protocol for url "lp-147262220:///~bdrung/5-a-day-data/main/.bzr/branch/lock"

[Benjamin Drung (bdrung)]

Running "bzr break-lock bzr+ssh://<email address hidden>/~bdrung/5-a-day-data/main/" instead of "bzr break-lock lp-147262220:///~bdrung/5-a-day-data/main/.bzr/branch/lock" works.

[Caspar Clemens Mierau (leitmedium)]

I noticed the following:

When adding two bugs at nearly the same time (adding the second while the first is in progress), you'll get a 104 error for second bug first, then get an ok message for the first message. When you retry adding the second bug, you'll be informed that it has been already added.

[Markus Korn (thekorn)]

Such errors happend because of how bad is threading done in the applet, it is far away from being threadsafe.
So maybe the applet needs a worker queue to handle all events in the right order.

Markus

[Daniel Holbach (dholbach)]

The 5-a-day tool and the 5-a-day-applet are mostly obsolete now. The only thing that still works is "5-a-day --update" for those who want it.

Just join https://launchpad.net/~5-a-day-participants and the rest will happen automatically. Some statistics on http://daniel.holba.ch/five-a-day-stats are not there yet, but will come soon. Bug data is now retrieved "automatically" from Launchpad.