Playing local files does not use information from the database

[Olivier Tilloy]

From bug #256117.
When playing an audio or video file from the filesystem controller, no query to the database is performed to check whether we have useful information (like the track number and track title) to display instead of just the filename in the player OSD.

Steps to reproduce:
1) Start Elisa, go to Music/Music Library/Tracks
2) Play a track for which you know the file is tagged (e.g. ID3 tags for an MP3 file), i.e. for which a track number and track title are displayed
3) Notice how the player OSD displays the track title
4) Now go to Music/Music Library/Folders and browse into the folder that contains the track you previously played
5) Play the track

Expected result: the track title as indexed in the database is displayed in the player OSD
Current result: the filename is displayed in the player OSD

[Michael Terry (mterry)]

Here's a patch. It only works on music files (though could easily be extended for other types), and I tested the patch using an older version of Elisa that didn't allow multiple files. So when I ported to bzr HEAD, I modified the patch, but didn't test. So you might want to look at this very closely. ;)

It checks the database for the file, and if found, uses the model from there. Else, just defaults to traditional PlayableModel with not much info.

[Philippe Normand (philn)]

That patch looks indeed wrong. I see at least a line that will trigger a NameError:

dfr.addCallback(enqueu, self.music_player.player.enqueue_to_playlist)

Will rework this...

[Philippe Normand (philn)]

And that patch is for the poblesec play_files() method, which is not used by the "filesystem" controller.. so totally unrelated with this bug.

[Philippe Normand (philn)]

working on proper patch for filesystem controller

[dino99 (9d9)]

The latest free moovida 1.09 does not get any maintenance since a while. Now moovidadb.com is supporting Linux and support can be found at : http://www.fluendo.com/faq/