[requestsync] Doesn't wait for gpg command to exit

[Jelmer Vernooij]

  affects ubuntu-dev-tools

requestsync doesn't wait for the gpg command to finish - it has exited
before I even had the ability to enter the PIN for my GPG smartcard.

ganieda:/data/jelmer/ubuntu-dev-tools/trunk% LC_ALL=C ./requestsync -s
-n bzr-cvsps-import intrepid
can't connect to `/tmp/gpg-GZP2tf/S.gpg-agent': No such file or
directory
gpg: can't connect to the agent - trying fall back
can't connect to `/home/jelmer/.gnupg/S.gpg-agent': No such file or
directory
scdaemon[16713]: signatures created so far: 6888
scdaemon[16713]: DBG: asking for PIN '||Please enter the PIN%0A[sigs
done: 6888]'
scdaemon[16713]: updating status of slot 0 to 0x0007
scdaemon[16713]: client pid is 16712, sending signal 12
gpg: signing failed: End of file
gpg: [stdin]: clearsign failed: End of file
scdaemon[16713]: PIN callback returned error: End of file
scdaemon[16713]: card_sign failed: End of file
Traceback (most recent call last):
  File "./requestsync", line 446, in <module>
    if mail_bug(srcpkg, subscribe, status, title, report, keyid):
  File "./requestsync", line 170, in mail_bug
    assert gpg.returncode == 0
AssertionError

--
Jelmer Vernooij <email address hidden> - http://samba.org/~jelmer/
Jabber: <email address hidden>

[Michael Bienia (geser)]

Does this still happen?

[Stefano Rivera (stefanor)]

The code doesn't have any kind of timeout, I'm guessing your gpg command exited.

gpg = subprocess.Popen(gpg_command, stdin = subprocess.PIPE, stdout = subprocess.PIPE)
signed_report = gpg.communicate(mailbody.encode('utf-8'))[0].decode('utf-8')
assert gpg.returncode == 0

[Launchpad Janitor (janitor)]

[Expired for ubuntu-dev-tools (Ubuntu) because there has been no activity for 60 days.]