traceback when branching from bzr+http

[Martin Albisetti]

When trying to branch from Peng's server with bzr.dev at revno 3602, I get a traceback.
His server is serving through bzr+http with lighthttpd, with bzr.dev at 3602 too.

beuno@beuno-laptop:~/bzr_devel/loggerhead$ bzr branch http://bzr.mattnordhoff.com/bzr/loggerhead/dirlisting-revno-link
bzr: ERROR: exceptions.NotImplementedError: <bound method HttpTransport_urllib._read_bytes of <bzrlib.transport.http._urllib.HttpTransport_urllib url=http://bzr.mattnordhoff.com/bzr/loggerhead/dirlisting-revno-link/>>

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 857, in run_bzr_catch_errors
    return run_bzr(argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 797, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.5/site-packages/bzrlib/commands.py", line 499, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.5/site-packages/bzrlib/builtins.py", line 826, in run
    from_location)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 886, in open_tree_or_branch
    bzrdir = klass.open(location)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 764, in open
    return BzrDir.open_from_transport(t, _unsupported=_unsupported)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 801, in open_from_transport
    redirected)
  File "/usr/lib/python2.5/site-packages/bzrlib/lazy_import.py", line 125, in __call__
    return obj(*args, **kwargs)
  File "/usr/lib/python2.5/site-packages/bzrlib/transport/__init__.py", line 1616, in do_catching_redirections
    return action(transport)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 778, in find_format
    transport, _server_formats=_server_formats)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 1601, in find_format
    return format.probe_transport(transport)
  File "/usr/lib/python2.5/site-packages/bzrlib/bzrdir.py", line 2588, in probe_transport
    server_version = medium.protocol_version()
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/medium.py", line 510, in protocol_version
    client_protocol.query_version()
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/protocol.py", line 723, in query_version
    resp = self.read_response_tuple()
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/protocol.py", line 638, in read_response_tuple
    result = self._read_response_tuple()
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/protocol.py", line 622, in _read_response_tuple
    result = self._recv_tuple()
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/protocol.py", line 718, in _recv_tuple
    return _decode_tuple(self._request.read_line())
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/medium.py", line 441, in read_line
    line = self._medium._get_line()
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/medium.py", line 137, in _get_line
    new_bytes = self.read_bytes(1)
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/medium.py", line 121, in read_bytes
    return self._read_bytes(bytes_to_read)
  File "/usr/lib/python2.5/site-packages/bzrlib/smart/medium.py", line 124, in _read_bytes
    raise NotImplementedError(self._read_bytes)
NotImplementedError: <bound method HttpTransport_urllib._read_bytes of <bzrlib.transport.http._urllib.HttpTransport_urllib url=http://bzr.mattnordhoff.com/bzr/loggerhead/dirlisting-revno-link/>>

bzr 1.6b4 on python 2.5.2 (linux2)
arguments: ['/usr/bin/bzr', 'branch', 'http://bzr.mattnordhoff.com/bzr/loggerhead/dirlisting-revno-link']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  command_not_found /home/beuno/.bazaar/plugins/command_not_found [0.1.0]
  gtk /home/beuno/.bazaar/plugins/gtk [0.95.0dev1]
  launchpad /usr/lib/python2.5/site-packages/bzrlib/plugins/launchpad [unknown]
  massupdate /home/beuno/.bazaar/plugins/massupdate [unknown]
  plugin_info /home/beuno/.bazaar/plugins/plugin_info [1.3.0dev0]
  rebase /home/beuno/.bazaar/plugins/rebase [0.3.0]
  search /home/beuno/.bazaar/plugins/search [1.6.0dev2]
  stats /home/beuno/.bazaar/plugins/stats [unknown]
  upload /home/beuno/.bazaar/plugins/upload [0.1.0]
  vimdiff /home/beuno/.bazaar/plugins/vimdiff [unknown]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

[Andrew Bennetts (spiv)]

I see this bug. It's a regression in 1.6. I have a tentative fix, I'll polish it and try to get John to include it in 1.6 final.