SilvaNews inline viewer doesn't work with Silva trunk

[Wim Boucquaert]

When using Silva trunk and Silva News trunk the Inline new viewer doesn't work.
When you add the inv cs to a document all parameters are lost and therefore also breaking the code source when saving and publishing the document.

[Andy Altepeter (aaltepet)]

This is partially fixed -- there was a forward-port of a fix for external sources -- now invalid (I believe) since the code had been refactored in the trunk. For me, this seemed to be a general problem with all external sources.

Part of the problem was that the parameters for the form weren't being added to the <div> for the external source in the document. This is now fixed.

The other part of the problem is that clicking an existing external source should load the ES form with the parameters for the ES. This is not happening and is still broken.

[Eric Casteleijn (thisfred)]

This should have been communicated, but the html structure of the divs that represent external sources have changed since having the parameter values in html attributes turned out to be very problematic in some edge cases concerning list values with unicode characters or quotes in them.

[Eric Casteleijn (thisfred)]

Meaning I reverted the revert. Also kupu would probably have broken with this revert, since there are changes in External Sources and SilvaDocument that depend on it.

[Eric Casteleijn (thisfred)]

Looks like SilvaNews will have to be fixed. I didn't realize that there was anything creating its own version of the kupu html. I wonder what is different abou these external sources that they can't just use the infrastructure in Silva/SilvaDocument/SilvaExternalSources? I'll do some digging.

[Eric Casteleijn (thisfred)]

Fixed (in silva itself)