typo in gtk progress test code

Bug #252824 reported by Anders F Björklund
2
Affects Status Importance Assigned to Milestone
Smart Package Manager
Fix Released
Low
Gustavo Niemeyer

Bug Description

A "True" parameter went to the wrong place, breaking the test main

Related branches

Revision history for this message
Anders F Björklund (afb) wrote :
Revision history for this message
netmask (netmask) wrote :

Can you please show a use/case scenario where it breaks that motivated you to create the patch?

Revision history for this message
Anders F Björklund (afb) wrote :

Did you try running it, for the test code ?

# progress.py, line 302
TypeError: __init__() takes exactly 2 arguments (1 given)

# progress.py, line 306
TypeError: start() takes exactly 1 argument (2 given)

Changed in smart:
importance: Undecided → Low
Revision history for this message
Anders F Björklund (afb) wrote :

Another problem was that sysconf is not available during tests,
so it can't be used to determine icon size (like added in r828)

Revision history for this message
Anders F Björklund (afb) wrote :
Changed in smart:
milestone: none → 1.2
Changed in smart:
milestone: 1.2 → 1.1.2
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

That's been fixed in trunk. I've called smart.init() to initialize sysconf rather than adding the dubious hack to catch AttributeError.

Changed in smart:
assignee: nobody → niemeyer
status: New → Fix Committed
Revision history for this message
Anders F Björklund (afb) wrote :

Released, 2009-03-04

Changed in smart:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.