Merge proposal page has navigation menu with no highlighted item

[Matthew Paul Thomas]

A merge proposal page, such as <https://code.edge.launchpad.net/~beuno/loggerhead/new_theme_trunk/+merge/564>, has a navigation menu with "Details", "Merging", and "Source Code" items. But none of these items are highlighted.

"Merging" should be highlighted, because the page for a specific merge proposal is a sub-page of the main "Merging" page that lists all merge proposals for the source branch.

[Tim Penhey (thumper)]

But what of the case where we have a branch targetted at two different branches.

For example:
  ~me/project/fix-bug-12345
     -> ~team/project/trunk
     -> ~team/project/1.1

In this case the general merging tab would list these two proposed merges.

To have the merging tab also highlighted for a single proposal makes it hard to go back the list of them.

While it is likely to be unusual for a branch to be both a source and target branch, it is possible and there are conceivable situations where it would be desirable, so having a situation that means that we can't have a listing as well as the detail view is not good.

[Martin Albisetti (beuno)]

I can see the corner-case, and, we should figure out something better for the sub-menu navigation.

For now, I'd say having /+merges be highlighted is a good start. It will look awkward when you go into the merge proposal and it's not selected, but that will take us half-way there.

[Matthew Paul Thomas (mpt)]

Tim, I don't understand why "To have the merging tab also highlighted for a single proposal makes it hard to go back [to] the list of them." Why would it make it hard?

As a comparison, there is more than one bug report filed against launchpad-bazaar. But that the "Bugs" tab is highlighted on the page for each of those bug reports doesn't make it difficult to go back to the list of them.

[Tim Penhey (thumper)]

Fixed in RF 7195.

No more navigation menu.