assumes source_branch format is the same as result branch format

Bug #251871 reported by Jelmer Vernooij
2
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Critical
Andrew Bennetts

Bug Description

since <email address hidden> , "bzr branch" will assume that the same format is to be used for the target branch as for the source branch. This breaks branching with bzr-svn since there is no way to create a SvnBranch inside of a bzr control dir.

bzrlib/bzrdir.py:1103 is the line that breaks. Is there any chance result_branch = result.create_branch() can be used instead?

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Marking as high since it makes bzr-svn unusable

Changed in bzr:
importance: Undecided → High
milestone: none → 1.6
Martin Pool (mbp)
Changed in bzr:
assignee: nobody → mbp
Revision history for this message
Martin Pool (mbp) wrote :

Just doing result.create_branch is not enough by itself, because we do need to override the format to make sure it is one that supports stacking...

Martin Pool (mbp)
Changed in bzr:
importance: High → Critical
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

FWIW, The attached patch works around this problem for bzr-svn, although it's obviously not fit to go into bzr.dev.

Revision history for this message
Martin Pool (mbp) wrote :
Changed in bzr:
status: New → Fix Committed
Revision history for this message
Andrew Bennetts (spiv) wrote :

The fix for this has now landed in bzr.dev.

Changed in bzr:
assignee: mbp → spiv
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.