unable to use keyboard context key

Bug #251679 reported by Y W Sing
2
Affects Status Importance Assigned to Milestone
Terminator
Fix Released
Undecided
Chris Jones

Bug Description

In gnome-terminal the context key (the key left to right-Ctrl) would pop up the right-click menu. However it does not work in terminator.

FYI, I've got the "TypeError" error message from terminator output just after pressing the context key:

ywsing@pct120:/opt/terminator-0.9$ ./terminator

(terminator:6331): Vte-WARNING **: Error compiling regular expression "[[:<:]](news:|telnet:|nntp:|file:/|https?:|ftps?:|webcal:)//([-A-Za-z0-9]+(:[-A-Za-z0-9,?;.:/!%$^*&~"#']+)?@)?[-A-Za-z0-9.]+(:[0-9]+)?(/[-A-Za-z0-9_$.+!*(),;:@&=?/~#%']*[^]'.}>)
,\"])?[[:>:]]/?".
TypeError: on_vte_popup_menu() takes exactly 3 arguments (2 given)

I have attached a patch that works on my machine.

My version is terminator 0.9 in Ubuntu 8.04 (i686). Thanks for your help.

Revision history for this message
Y W Sing (stupidsing) wrote :
Revision history for this message
Y W Sing (stupidsing) wrote :

Chris can you retry the patch... I am not sure I generated it right before in the email. Was my first time to do a patch.

This attachment from 'bzr diff' should be correct.

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Doesn't work for me on the development version, i'm not getting the error or the menu after aplying the patch.

Revision history for this message
Y W Sing (stupidsing) wrote :

Can you pop up the menu by context key in gnome-terminal?

I wonder if vte is calling on_vte_popup_menu after the keypress in your side. This could be easily found out by inserting a print. And I can confirm on_vte_keypress() is called with keyname = "Menu" for the keypress.

My lib versions, if this could matter:

$ dpkg -l|grep vte
ii libvte-common 1:0.16.13-1ubuntu1 Terminal emulator widget for GTK+ 2.0 - comm
ii libvte9 1:0.16.13-1ubuntu1 Terminal emulator widget for GTK+ 2.0 - runt
ii python-vte 1:0.16.13-1ubuntu1 Python bindings for the VTE widget set

Revision history for this message
Chris Jones (cmsj) wrote :

YWSing: could you run "xev" and then press that key? When I do that, this is one of the entries I get:

KeyPress event, serial 31, synthetic NO, window 0x3000001,
    root 0x59, subw 0x0, time 287859852, (72,-16), root:(79,40),
    state 0x0, keycode 227 (keysym 0x0, NoSymbol), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

I suspect that this is different to what yours generates, but I have no idea why (and the fact that my keyboard is generating an event different from "Menu" doesn't mean that your patch is wrong.

Revision history for this message
Y W Sing (stupidsing) wrote :

Chris, I got this:

KeyPress event, serial 28, synthetic NO, window 0x3a00001,
    root 0x58, subw 0x0, time 29684688, (-467,156), root:(371,208),
    state 0x0, keycode 117 (keysym 0xff67, Menu), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

KeyRelease event, serial 31, synthetic NO, window 0x3a00001,
    root 0x58, subw 0x0, time 29684745, (-467,156), root:(371,208),
    state 0x0, keycode 117 (keysym 0xff67, Menu), same_screen YES,
    XLookupString gives 0 bytes:
    XFilterEvent returns: False

Actually it worked in two computers I used (both Ubuntu 8.04).

Chris Jones (cmsj)
Changed in terminator:
milestone: none → 1.0-beta
status: New → Confirmed
Revision history for this message
Thomas Hurst (tom.hurst) wrote :
Changed in terminator:
assignee: nobody → cmsj
status: Confirmed → Fix Committed
Chris Jones (cmsj)
Changed in terminator:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.