unable to get mtime for renamed file from PreviewTree
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Undecided
|
Aaron Bentley | ||
QBzr |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
This bug affects QBzr actually, but it's still bug.
QBzr 0.9.2 provide additional option `--qpreview` for `merge` command. For preview used qdiff window with side-by-side view (by default). Side-by-side view needs to know timestamp of file from old and new tree. To obtain timestamp QBzr used construct like this (not exactly this):
date = tree.get_
This code fails with error when you want to preview merge in which some file only renamed but not modified. Here is traceback:
C:\Temp\1>python C:\work\
Traceback (most recent call last):
File "C:\work\
dates[ix] = self.trees[
File "C:\work\
return self._transform
File "C:\work\
return os.lstat(
WindowsError: [Error 2] : u'C:/Temp/1/foo'
Regular merge --preview is not affected by this bug, because it don't try to show timestamp at all:
C:\Temp\1>python C:\work\
=== renamed file 'bar' => 'foo'
Here the body of get_file_mtime in transform.py:
def get_file_
"""See Tree.get_
if not self._content_
return self._transform
return self._stat_
Obviously content is not changed in the case of rename.
Related branches
- Robert Collins (community): Needs Fixing
- Diff: None lines
Changed in qbzr: | |
status: | New → Confirmed |
Changed in bzr: | |
milestone: | none → 2.1.0b1 |
status: | In Progress → Fix Released |
assignee: | nobody → Aaron Bentley (abentley) |
qbzr has workaround for this bug.